arm64: dts: rockchip: fix rk356x pcie msg interrupt name

[PATCH] arm64: dts: rockchip: fix rk356x pcie msg interrupt name

Posted by Heiko Stuebner 2 years, 1 month ago

The expected name by the binding at this position is "msg" and the SoC's
manual also calls the interrupt in question "msg", so fix the rk356x dtsi
to use the correct name.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
index 0964761e3ce9..c19c0f1b3778 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
@@ -977,7 +977,7 @@ pcie2x1: pcie@fe260000 {
 			     <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
-		interrupt-names = "sys", "pmc", "msi", "legacy", "err";
+		interrupt-names = "sys", "pmc", "msg", "legacy", "err";
 		bus-range = <0x0 0xf>;
 		clocks = <&cru ACLK_PCIE20_MST>, <&cru ACLK_PCIE20_SLV>,
 			 <&cru ACLK_PCIE20_DBI>, <&cru PCLK_PCIE20>,
-- 
2.39.2

Re: [PATCH] arm64: dts: rockchip: fix rk356x pcie msg interrupt name

Posted by Heiko Stuebner 2 years, 1 month ago

On Tue, 14 Nov 2023 16:38:34 +0100, Heiko Stuebner wrote:
> The expected name by the binding at this position is "msg" and the SoC's
> manual also calls the interrupt in question "msg", so fix the rk356x dtsi
> to use the correct name.
> 
> 

Applied, thanks!

[1/1] arm64: dts: rockchip: fix rk356x pcie msg interrupt name
      commit: 3cee9c635f27d1003d46f624d816f3455698b625

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: [PATCH] arm64: dts: rockchip: fix rk356x pcie msg interrupt name

Posted by Sebastian Reichel 2 years, 1 month ago

Hi,

On Tue, Nov 14, 2023 at 04:38:34PM +0100, Heiko Stuebner wrote:
> The expected name by the binding at this position is "msg" and the SoC's
> manual also calls the interrupt in question "msg", so fix the rk356x dtsi
> to use the correct name.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> ---
>  arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> index 0964761e3ce9..c19c0f1b3778 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> @@ -977,7 +977,7 @@ pcie2x1: pcie@fe260000 {
>  			     <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
>  			     <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
>  			     <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> -		interrupt-names = "sys", "pmc", "msi", "legacy", "err";
> +		interrupt-names = "sys", "pmc", "msg", "legacy", "err";
>  		bus-range = <0x0 0xf>;
>  		clocks = <&cru ACLK_PCIE20_MST>, <&cru ACLK_PCIE20_SLV>,
>  			 <&cru ACLK_PCIE20_DBI>, <&cru PCLK_PCIE20>,
> -- 
> 2.39.2
>