[PATCH 00/20] remove I2C_CLASS_DDC support

Heiner Kallweit posted 20 patches 1 year ago
There is a newer version of this series
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c           |    1 -
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    1 -
drivers/gpu/drm/ast/ast_i2c.c                     |    1 -
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c         |    1 -
drivers/gpu/drm/display/drm_dp_helper.c           |    1 -
drivers/gpu/drm/display/drm_dp_mst_topology.c     |    1 -
drivers/gpu/drm/gma500/cdv_intel_dp.c             |    1 -
drivers/gpu/drm/gma500/intel_gmbus.c              |    1 -
drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c        |    1 -
drivers/gpu/drm/gma500/psb_intel_sdvo.c           |    1 -
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c   |    1 -
drivers/gpu/drm/i915/display/intel_gmbus.c        |    1 -
drivers/gpu/drm/i915/display/intel_sdvo.c         |    1 -
drivers/gpu/drm/loongson/lsdc_i2c.c               |    1 -
drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c           |    1 -
drivers/gpu/drm/mgag200/mgag200_i2c.c             |    1 -
drivers/gpu/drm/msm/hdmi/hdmi_i2c.c               |    1 -
drivers/gpu/drm/radeon/radeon_i2c.c               |    1 -
drivers/gpu/drm/rockchip/inno_hdmi.c              |    1 -
drivers/gpu/drm/rockchip/rk3066_hdmi.c            |    1 -
drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c            |    1 -
drivers/video/fbdev/core/fb_ddc.c                 |    1 -
drivers/video/fbdev/cyber2000fb.c                 |    1 -
drivers/video/fbdev/i740fb.c                      |    1 -
drivers/video/fbdev/intelfb/intelfb_i2c.c         |   15 +++++----------
drivers/video/fbdev/matrox/i2c-matroxfb.c         |   12 ++++--------
drivers/video/fbdev/s3fb.c                        |    1 -
drivers/video/fbdev/tdfxfb.c                      |    1 -
drivers/video/fbdev/tridentfb.c                   |    1 -
drivers/video/fbdev/via/via_i2c.c                 |    1 -
include/linux/i2c.h                               |    1 -
31 files changed, 9 insertions(+), 47 deletions(-)
[PATCH 00/20] remove I2C_CLASS_DDC support
Posted by Heiner Kallweit 1 year ago
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.

Preferably this series should be applied via the i2c tree.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

---

 drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c           |    1 -
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    1 -
 drivers/gpu/drm/ast/ast_i2c.c                     |    1 -
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c         |    1 -
 drivers/gpu/drm/display/drm_dp_helper.c           |    1 -
 drivers/gpu/drm/display/drm_dp_mst_topology.c     |    1 -
 drivers/gpu/drm/gma500/cdv_intel_dp.c             |    1 -
 drivers/gpu/drm/gma500/intel_gmbus.c              |    1 -
 drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c        |    1 -
 drivers/gpu/drm/gma500/psb_intel_sdvo.c           |    1 -
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c   |    1 -
 drivers/gpu/drm/i915/display/intel_gmbus.c        |    1 -
 drivers/gpu/drm/i915/display/intel_sdvo.c         |    1 -
 drivers/gpu/drm/loongson/lsdc_i2c.c               |    1 -
 drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c           |    1 -
 drivers/gpu/drm/mgag200/mgag200_i2c.c             |    1 -
 drivers/gpu/drm/msm/hdmi/hdmi_i2c.c               |    1 -
 drivers/gpu/drm/radeon/radeon_i2c.c               |    1 -
 drivers/gpu/drm/rockchip/inno_hdmi.c              |    1 -
 drivers/gpu/drm/rockchip/rk3066_hdmi.c            |    1 -
 drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c            |    1 -
 drivers/video/fbdev/core/fb_ddc.c                 |    1 -
 drivers/video/fbdev/cyber2000fb.c                 |    1 -
 drivers/video/fbdev/i740fb.c                      |    1 -
 drivers/video/fbdev/intelfb/intelfb_i2c.c         |   15 +++++----------
 drivers/video/fbdev/matrox/i2c-matroxfb.c         |   12 ++++--------
 drivers/video/fbdev/s3fb.c                        |    1 -
 drivers/video/fbdev/tdfxfb.c                      |    1 -
 drivers/video/fbdev/tridentfb.c                   |    1 -
 drivers/video/fbdev/via/via_i2c.c                 |    1 -
 include/linux/i2c.h                               |    1 -
 31 files changed, 9 insertions(+), 47 deletions(-)
Re: [PATCH 00/20] remove I2C_CLASS_DDC support
Posted by Wolfram Sang 1 year ago
> Preferably this series should be applied via the i2c tree.

Are we in a hurry here, i.e. does it block further development of the
i801 smbus driver? My gut feeling says the patches should rather go via
drm and fbdev trees, but I may be convinced otherwise.

Re: [PATCH 00/20] remove I2C_CLASS_DDC support
Posted by Heiner Kallweit 1 year ago
On 13.11.2023 18:49, Wolfram Sang wrote:
> 
>> Preferably this series should be applied via the i2c tree.
> 
> Are we in a hurry here, i.e. does it block further development of the
> i801 smbus driver? My gut feeling says the patches should rather go via
> drm and fbdev trees, but I may be convinced otherwise.
> 
We're not in a hurry. It's just my experience with patch series' affecting
multiple subsystems that typically the decision was to apply the full
series via one tree. Also to avoid inquires from maintainers like:
Shall I take it or are you going to take it?
Of course there may be different opinions. Please advise.
Re: [PATCH 00/20] remove I2C_CLASS_DDC support
Posted by Wolfram Sang 1 year ago
> We're not in a hurry. It's just my experience with patch series' affecting
> multiple subsystems that typically the decision was to apply the full
> series via one tree. Also to avoid inquires from maintainers like:
> Shall I take it or are you going to take it?
> Of course there may be different opinions. Please advise.

Ok, then this turns out to be a negotation thing between the drm/fbdev
maintainers and me. I *can* take all the patches, of course. But since
the number of patches touching the non-i2c subsystems is high, I'd like
to hear their preference, too.

Re: [PATCH 00/20] remove I2C_CLASS_DDC support
Posted by Alex Deucher 12 months ago
On Mon, Nov 13, 2023 at 3:55 PM Wolfram Sang <wsa@kernel.org> wrote:
>
>
> > We're not in a hurry. It's just my experience with patch series' affecting
> > multiple subsystems that typically the decision was to apply the full
> > series via one tree. Also to avoid inquires from maintainers like:
> > Shall I take it or are you going to take it?
> > Of course there may be different opinions. Please advise.
>
> Ok, then this turns out to be a negotation thing between the drm/fbdev
> maintainers and me. I *can* take all the patches, of course. But since
> the number of patches touching the non-i2c subsystems is high, I'd like
> to hear their preference, too.
>

I don't have a preference if you would prefer to take these via i2c.

Alex