[PATCH] bcachefs: Fix potential sleeping during mount

Daniel J Blueman posted 1 patch 2 years, 1 month ago
fs/bcachefs/disk_groups.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] bcachefs: Fix potential sleeping during mount
Posted by Daniel J Blueman 2 years, 1 month ago
During mount, bcachefs mount option processing may sleep while allocating a string buffer.

Fix this by reference counting in order to take the atomic path.

Signed-off-by: Daniel J Blueman <daniel@quora.org>
---
 fs/bcachefs/disk_groups.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/bcachefs/disk_groups.c b/fs/bcachefs/disk_groups.c
index 1f334124055b..4d0cb0ccff32 100644
--- a/fs/bcachefs/disk_groups.c
+++ b/fs/bcachefs/disk_groups.c
@@ -555,6 +555,7 @@ void bch2_target_to_text(struct printbuf *out, struct bch_fs *c, unsigned v)
 	case TARGET_DEV: {
 		struct bch_dev *ca;
 
+		out->atomic++;
 		rcu_read_lock();
 		ca = t.dev < c->sb.nr_devices
 			? rcu_dereference(c->devs[t.dev])
@@ -570,6 +571,7 @@ void bch2_target_to_text(struct printbuf *out, struct bch_fs *c, unsigned v)
 		}
 
 		rcu_read_unlock();
+		out->atomic--;
 		break;
 	}
 	case TARGET_GROUP:
-- 
2.40.1
Re: [PATCH] bcachefs: Fix potential sleeping during mount
Posted by Kent Overstreet 2 years, 1 month ago
On Sun, Nov 12, 2023 at 12:38:41AM +0000, Daniel J Blueman wrote:
> During mount, bcachefs mount option processing may sleep while allocating a string buffer.
> 
> Fix this by reference counting in order to take the atomic path.
> 
> Signed-off-by: Daniel J Blueman <daniel@quora.org>

Thanks, applied