1. Patchew
  2. linux
  3. [PATCH v3 00/25] i2c: designware: code consolidation & cleanups
  4. View patch

[PATCH v3 10/25] i2c: designware: Unify terminator in device ID tables

Andy Shevchenko posted 25 patches 2 years, 1 month ago
There is a newer version of this series
[PATCH v3 10/25] i2c: designware: Unify terminator in device ID tables
Posted by Andy Shevchenko 2 years, 1 month ago 
Make the terminator entry look the same in all device ID tables.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/i2c/busses/i2c-designware-pcidrv.c  | 2 +-
 drivers/i2c/busses/i2c-designware-platdrv.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
index db642e0aa61f..7f04dc33e6f7 100644
--- a/drivers/i2c/busses/i2c-designware-pcidrv.c
+++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
@@ -402,7 +402,7 @@ static const struct pci_device_id i2c_designware_pci_ids[] = {
 	{ PCI_VDEVICE(ATI,  0x73c4), navi_amd },
 	{ PCI_VDEVICE(ATI,  0x7444), navi_amd },
 	{ PCI_VDEVICE(ATI,  0x7464), navi_amd },
-	{ 0,}
+	{}
 };
 MODULE_DEVICE_TABLE(pci, i2c_designware_pci_ids);
 
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 5d8427ccc9b4..018c353a456a 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -57,7 +57,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
 	{ "HISI02A2", 0 },
 	{ "HISI02A3", 0 },
 	{ "HYGO0010", ACCESS_INTR_MASK },
-	{ }
+	{}
 };
 MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
 #endif
@@ -153,7 +153,7 @@ static const struct of_device_id dw_i2c_of_match[] = {
 	{ .compatible = "snps,designware-i2c", },
 	{ .compatible = "mscc,ocelot-i2c", .data = (void *)MODEL_MSCC_OCELOT },
 	{ .compatible = "baikal,bt1-sys-i2c", .data = (void *)MODEL_BAIKAL_BT1 },
-	{},
+	{}
 };
 MODULE_DEVICE_TABLE(of, dw_i2c_of_match);
 #else
-- 
2.43.0.rc1.1.gbec44491f096
Re: [PATCH v3 10/25] i2c: designware: Unify terminator in device ID tables
Posted by Jarkko Nikula 2 years ago 
On 11/10/23 20:11, Andy Shevchenko wrote:
> Make the terminator entry look the same in all device ID tables.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   drivers/i2c/busses/i2c-designware-pcidrv.c  | 2 +-
>   drivers/i2c/busses/i2c-designware-platdrv.c | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Re: [PATCH v3 10/25] i2c: designware: Unify terminator in device ID tables
Posted by Mario Limonciello 2 years, 1 month ago 
On 11/10/2023 12:11, Andy Shevchenko wrote:
> Make the terminator entry look the same in all device ID tables.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   drivers/i2c/busses/i2c-designware-pcidrv.c  | 2 +-
>   drivers/i2c/busses/i2c-designware-platdrv.c | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index db642e0aa61f..7f04dc33e6f7 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -402,7 +402,7 @@ static const struct pci_device_id i2c_designware_pci_ids[] = {
>   	{ PCI_VDEVICE(ATI,  0x73c4), navi_amd },
>   	{ PCI_VDEVICE(ATI,  0x7444), navi_amd },
>   	{ PCI_VDEVICE(ATI,  0x7464), navi_amd },
> -	{ 0,}
> +	{}
>   };
>   MODULE_DEVICE_TABLE(pci, i2c_designware_pci_ids);
>   
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 5d8427ccc9b4..018c353a456a 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -57,7 +57,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
>   	{ "HISI02A2", 0 },
>   	{ "HISI02A3", 0 },
>   	{ "HYGO0010", ACCESS_INTR_MASK },
> -	{ }
> +	{}
>   };
>   MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
>   #endif
> @@ -153,7 +153,7 @@ static const struct of_device_id dw_i2c_of_match[] = {
>   	{ .compatible = "snps,designware-i2c", },
>   	{ .compatible = "mscc,ocelot-i2c", .data = (void *)MODEL_MSCC_OCELOT },
>   	{ .compatible = "baikal,bt1-sys-i2c", .data = (void *)MODEL_BAIKAL_BT1 },
> -	{},
> +	{}
>   };
>   MODULE_DEVICE_TABLE(of, dw_i2c_of_match);
>   #else
Re: [PATCH v3 10/25] i2c: designware: Unify terminator in device ID tables
Posted by Jarkko Nikula 2 years ago 
On 11/10/23 21:38, Mario Limonciello wrote:
> On 11/10/2023 12:11, Andy Shevchenko wrote:
>> Make the terminator entry look the same in all device ID tables.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

Sorry replying twice, wanted to make sure Mario's tag is noted.

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Re: [PATCH v3 10/25] i2c: designware: Unify terminator in device ID tables
Posted by Andy Shevchenko 2 years ago 
On Fri, Nov 17, 2023 at 04:18:13PM +0200, Jarkko Nikula wrote:
> On 11/10/23 21:38, Mario Limonciello wrote:
> > On 11/10/2023 12:11, Andy Shevchenko wrote:
> > > Make the terminator entry look the same in all device ID tables.
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> Sorry replying twice, wanted to make sure Mario's tag is noted.

I am using `b4`, it collects tags from the entire thread (each email from it),
so no need to send twice or care about other's tags).

> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

Thank you for the review!

-- 
With Best Regards,
Andy Shevchenko

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.