[v1] arm64: dts: amlogic: meson-axg: pinctrl node for NAND

[PATCH v1] arm64: dts: amlogic: meson-axg: pinctrl node for NAND

Posted by Arseniy Krasnov 2 years, 1 month ago

Add pinctrl node for the Meson NAND controller.

Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
---
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index a49aa62e3f9f..98a17953e969 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -432,6 +432,27 @@ mux-1 {
 					};
 				};
 
+				nand_all_pins: nand_all_pins {
+					mux {
+						groups = "emmc_nand_d0",
+							 "emmc_nand_d1",
+							 "emmc_nand_d2",
+							 "emmc_nand_d3",
+							 "emmc_nand_d4",
+							 "emmc_nand_d5",
+							 "emmc_nand_d6",
+							 "emmc_nand_d7",
+							 "nand_ce0",
+							 "nand_ale",
+							 "nand_cle",
+							 "nand_wen_clk",
+							 "nand_ren_wr";
+						function = "nand";
+						input-enable;
+						bias-pull-up;
+					};
+				};
+
 				emmc_ds_pins: emmc_ds {
 					mux {
 						groups = "emmc_ds";
@@ -1913,6 +1934,8 @@ nfc: nand-controller@7800 {
 				reg = <0x0 0x7800 0x0 0x100>,
 				      <0x0 0x7000 0x0 0x800>;
 				reg-names = "nfc", "emmc";
+				pinctrl-0 = <&nand_all_pins>;
+				pinctrl-names = "default";
 				#address-cells = <1>;
 				#size-cells = <0>;
 				interrupts = <GIC_SPI 34 IRQ_TYPE_EDGE_RISING>;
-- 
2.35.0

Re: [PATCH v1] arm64: dts: amlogic: meson-axg: pinctrl node for NAND

Posted by Krzysztof Kozlowski 2 years, 1 month ago

On 09/11/2023 06:30, Arseniy Krasnov wrote:
> Add pinctrl node for the Meson NAND controller.
> 
> Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index a49aa62e3f9f..98a17953e969 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -432,6 +432,27 @@ mux-1 {
>  					};
>  				};
>  
> +				nand_all_pins: nand_all_pins {

No underscores in node names. Doesn't dtbs_check point it?

Best regards,
Krzysztof

Re: [PATCH v1] arm64: dts: amlogic: meson-axg: pinctrl node for NAND

Posted by Arseniy Krasnov 2 years, 1 month ago


On 09.11.2023 11:54, Krzysztof Kozlowski wrote:
> On 09/11/2023 06:30, Arseniy Krasnov wrote:
>> Add pinctrl node for the Meson NAND controller.
>>
>> Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
>> ---
>>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 23 ++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> index a49aa62e3f9f..98a17953e969 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> @@ -432,6 +432,27 @@ mux-1 {
>>  					};
>>  				};
>>  
>> +				nand_all_pins: nand_all_pins {
> 
> No underscores in node names. Doesn't dtbs_check point it?

Ok, thanks, done in v2! No, dtbs_check passes ok in my case

Thanks, Arseniy

> 
> Best regards,
> Krzysztof
>