1. Patchew
  2. linux
  3. [PATCH v4 0/2] LTC4286 and LTC4287 driver support
  4. View patch

[PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings

Delphine CC Chiu posted 2 patches 2 years, 1 month ago
There is a newer version of this series
[PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings
Posted by Delphine CC Chiu 2 years, 1 month ago 
Add a device tree bindings for ltc4286 device.

Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>

Changelog:
  v4 - Revise some inappropriate writing in yaml file
  v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable
  v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6
     - Add type for adi,vrange-select-25p6
     - Revise rsense-micro-ohms to shunt-resistor-micro-ohms
---
 .../bindings/hwmon/lltc,ltc4286.yaml          | 51 +++++++++++++++++++
 MAINTAINERS                                   | 10 ++++
 2 files changed, 61 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
new file mode 100644
index 000000000000..d26f34fb7ea7
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LTC4286 power monitors
+
+maintainers:
+  - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
+
+properties:
+  compatible:
+    enum:
+      - lltc,ltc4286
+      - lltc,ltc4287
+
+  reg:
+    maxItems: 1
+
+  adi,vrange-low-enable:
+    description:
+      This property is a bool parameter to represent the
+      voltage range is 25.6 volts or 102.4 volts for this chip.
+      The default is 102.4 volts.
+    type: boolean
+
+  shunt-resistor-micro-ohms:
+    description:
+      Resistor value micro-ohms.
+
+required:
+  - compatible
+  - reg
+  - shunt-resistor-micro-ohms
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        power-monitor@40 {
+            compatible = "lltc,ltc4286";
+            reg = <0x40>;
+            adi,vrange-low-enable;
+            shunt-resistor-micro-ohms = <300>;
+        };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index 0b275b8d6bd2..5d439cd64ecb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12609,6 +12609,16 @@ S:	Maintained
 F:	Documentation/hwmon/ltc4261.rst
 F:	drivers/hwmon/ltc4261.c
 
+LTC4286 HARDWARE MONITOR DRIVER
+M:	Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
+L:	linux-i2c@vger.kernel.org
+S:	Maintained
+F:	Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
+F:	Documentation/devicetree/bindings/hwmon/ltc4286.rst
+F:	drivers/hwmon/pmbus/Kconfig
+F:	drivers/hwmon/pmbus/Makefile
+F:	drivers/hwmon/pmbus/ltc4286.c
+
 LTC4306 I2C MULTIPLEXER DRIVER
 M:	Michael Hennerich <michael.hennerich@analog.com>
 L:	linux-i2c@vger.kernel.org
-- 
2.25.1
Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings
Posted by Conor Dooley 2 years, 1 month ago 
On Thu, Nov 09, 2023 at 09:49:45AM +0800, Delphine CC Chiu wrote:
> Add a device tree bindings for ltc4286 device.
> 
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> 
> Changelog:
>   v4 - Revise some inappropriate writing in yaml file
>   v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable
>   v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6
>      - Add type for adi,vrange-select-25p6
>      - Revise rsense-micro-ohms to shunt-resistor-micro-ohms

Your changelog should be below the --- line.
You also omitted the tag I left on the previous version.
With the changelog fixed:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
>  .../bindings/hwmon/lltc,ltc4286.yaml          | 51 +++++++++++++++++++
>  MAINTAINERS                                   | 10 ++++
>  2 files changed, 61 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> new file mode 100644
> index 000000000000..d26f34fb7ea7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LTC4286 power monitors
> +
> +maintainers:
> +  - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - lltc,ltc4286
> +      - lltc,ltc4287
> +
> +  reg:
> +    maxItems: 1
> +
> +  adi,vrange-low-enable:
> +    description:
> +      This property is a bool parameter to represent the
> +      voltage range is 25.6 volts or 102.4 volts for this chip.
> +      The default is 102.4 volts.
> +    type: boolean
> +
> +  shunt-resistor-micro-ohms:
> +    description:
> +      Resistor value micro-ohms.
> +
> +required:
> +  - compatible
> +  - reg
> +  - shunt-resistor-micro-ohms
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        power-monitor@40 {
> +            compatible = "lltc,ltc4286";
> +            reg = <0x40>;
> +            adi,vrange-low-enable;
> +            shunt-resistor-micro-ohms = <300>;
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0b275b8d6bd2..5d439cd64ecb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12609,6 +12609,16 @@ S:	Maintained
>  F:	Documentation/hwmon/ltc4261.rst
>  F:	drivers/hwmon/ltc4261.c
>  
> +LTC4286 HARDWARE MONITOR DRIVER
> +M:	Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> +L:	linux-i2c@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> +F:	Documentation/devicetree/bindings/hwmon/ltc4286.rst
> +F:	drivers/hwmon/pmbus/Kconfig
> +F:	drivers/hwmon/pmbus/Makefile
> +F:	drivers/hwmon/pmbus/ltc4286.c
> +
>  LTC4306 I2C MULTIPLEXER DRIVER
>  M:	Michael Hennerich <michael.hennerich@analog.com>
>  L:	linux-i2c@vger.kernel.org
> -- 
> 2.25.1
> 
>
RE: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings
Posted by Delphine_CC_Chiu/WYHQ/Wiwynn 2 years, 1 month ago 
> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Friday, November 10, 2023 1:10 AM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>
> Cc: patrick@stwcx.xyz; Jean Delvare <jdelvare@suse.com>; Guenter Roeck
> <linux@roeck-us.net>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> Jonathan Corbet <corbet@lwn.net>; linux-i2c@vger.kernel.org;
> linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org
> Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver
> bindings
> 
> On Thu, Nov 09, 2023 at 09:49:45AM +0800, Delphine CC Chiu wrote:
> > Add a device tree bindings for ltc4286 device.
> >
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> >
> > Changelog:
> >   v4 - Revise some inappropriate writing in yaml file
> >   v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable
> >   v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6
> >      - Add type for adi,vrange-select-25p6
> >      - Revise rsense-micro-ohms to shunt-resistor-micro-ohms
> 
> Your changelog should be below the --- line.

We will add --- line on our changelog.

> You also omitted the tag I left on the previous version.

Could you point out the exact places that we omit?
Thanks.

> With the changelog fixed:
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Cheers,
> Conor.
> 
> > ---
> >  .../bindings/hwmon/lltc,ltc4286.yaml          | 51
> +++++++++++++++++++
> >  MAINTAINERS                                   | 10 ++++
> >  2 files changed, 61 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> > b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> > new file mode 100644
> > index 000000000000..d26f34fb7ea7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> > @@ -0,0 +1,51 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: LTC4286 power monitors
> > +
> > +maintainers:
> > +  - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - lltc,ltc4286
> > +      - lltc,ltc4287
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  adi,vrange-low-enable:
> > +    description:
> > +      This property is a bool parameter to represent the
> > +      voltage range is 25.6 volts or 102.4 volts for this chip.
> > +      The default is 102.4 volts.
> > +    type: boolean
> > +
> > +  shunt-resistor-micro-ohms:
> > +    description:
> > +      Resistor value micro-ohms.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - shunt-resistor-micro-ohms
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        power-monitor@40 {
> > +            compatible = "lltc,ltc4286";
> > +            reg = <0x40>;
> > +            adi,vrange-low-enable;
> > +            shunt-resistor-micro-ohms = <300>;
> > +        };
> > +    };
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > 0b275b8d6bd2..5d439cd64ecb 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -12609,6 +12609,16 @@ S:	Maintained
> >  F:	Documentation/hwmon/ltc4261.rst
> >  F:	drivers/hwmon/ltc4261.c
> >
> > +LTC4286 HARDWARE MONITOR DRIVER
> > +M:	Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> > +L:	linux-i2c@vger.kernel.org
> > +S:	Maintained
> > +F:	Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> > +F:	Documentation/devicetree/bindings/hwmon/ltc4286.rst
> > +F:	drivers/hwmon/pmbus/Kconfig
> > +F:	drivers/hwmon/pmbus/Makefile
> > +F:	drivers/hwmon/pmbus/ltc4286.c
> > +
> >  LTC4306 I2C MULTIPLEXER DRIVER
> >  M:	Michael Hennerich <michael.hennerich@analog.com>
> >  L:	linux-i2c@vger.kernel.org
> > --
> > 2.25.1
> >
> >
Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings
Posted by Krzysztof Kozlowski 2 years, 1 month ago 
On 15/11/2023 09:38, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
>> -----Original Message-----
>> From: Conor Dooley <conor@kernel.org>
>> Sent: Friday, November 10, 2023 1:10 AM
>> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>
>> Cc: patrick@stwcx.xyz; Jean Delvare <jdelvare@suse.com>; Guenter Roeck
>> <linux@roeck-us.net>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
>> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
>> Jonathan Corbet <corbet@lwn.net>; linux-i2c@vger.kernel.org;
>> linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org;
>> linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org
>> Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver
>> bindings
>>
>> On Thu, Nov 09, 2023 at 09:49:45AM +0800, Delphine CC Chiu wrote:
>>> Add a device tree bindings for ltc4286 device.
>>>
>>> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
>>>
>>> Changelog:
>>>   v4 - Revise some inappropriate writing in yaml file
>>>   v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable
>>>   v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6
>>>      - Add type for adi,vrange-select-25p6
>>>      - Revise rsense-micro-ohms to shunt-resistor-micro-ohms
>>
>> Your changelog should be below the --- line.
> 
> We will add --- line on our changelog.
> 
>> You also omitted the tag I left on the previous version.
> 
> Could you point out the exact places that we omit?

Open the previous email and read it fully. Did you or did you not get a tag?

> Thanks.
> 
>> With the changelog fixed:
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Best regards,
Krzysztof
RE: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings
Posted by Delphine_CC_Chiu/WYHQ/Wiwynn 2 years, 1 month ago 
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, November 15, 2023 8:18 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> Conor Dooley <conor@kernel.org>
> Cc: patrick@stwcx.xyz; Jean Delvare <jdelvare@suse.com>; Guenter Roeck
> <linux@roeck-us.net>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> Jonathan Corbet <corbet@lwn.net>; linux-i2c@vger.kernel.org;
> linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org
> Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver
> bindings
> 
>   Security Reminder: Please be aware that this email is sent by an external
> sender.
> 
> On 15/11/2023 09:38, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> >> -----Original Message-----
> >> From: Conor Dooley <conor@kernel.org>
> >> Sent: Friday, November 10, 2023 1:10 AM
> >> To: Delphine_CC_Chiu/WYHQ/Wiwynn
> <Delphine_CC_Chiu@wiwynn.com>
> >> Cc: patrick@stwcx.xyz; Jean Delvare <jdelvare@suse.com>; Guenter
> >> Roeck <linux@roeck-us.net>; Rob Herring <robh+dt@kernel.org>;
> >> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> >> <conor+dt@kernel.org>; Jonathan Corbet <corbet@lwn.net>;
> >> linux-i2c@vger.kernel.org; linux-hwmon@vger.kernel.org;
> >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> >> linux-doc@vger.kernel.org
> >> Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286
> >> driver bindings
> >>
> >> On Thu, Nov 09, 2023 at 09:49:45AM +0800, Delphine CC Chiu wrote:
> >>> Add a device tree bindings for ltc4286 device.
> >>>
> >>> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> >>>
> >>> Changelog:
> >>>   v4 - Revise some inappropriate writing in yaml file
> >>>   v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable
> >>>   v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6
> >>>      - Add type for adi,vrange-select-25p6
> >>>      - Revise rsense-micro-ohms to shunt-resistor-micro-ohms
> >>
> >> Your changelog should be below the --- line.
> >
> > We will add --- line on our changelog.
> >
> >> You also omitted the tag I left on the previous version.
> >
> > Could you point out the exact places that we omit?
> 
> Open the previous email and read it fully. Did you or did you not get a tag?

We realize the meaning of tag after survey.
We will add tag in commit message.
Thanks.

> 
> > Thanks.
> >
> >> With the changelog fixed:
> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Best regards,
> Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.