[PATCH 05/22] [RESEND] parport: gsc: mark init function static

Arnd Bergmann posted 22 patches 1 year, 10 months ago
[PATCH 05/22] [RESEND] parport: gsc: mark init function static
Posted by Arnd Bergmann 1 year, 10 months ago
From: Arnd Bergmann <arnd@arndb.de>

This is only used locally, so mark it static to avoid a warning:

drivers/parport/parport_gsc.c:395:5: error: no previous prototype for 'parport_gsc_init' [-Werror=missing-prototypes]

Acked-by: Helge Deller <deller@gmx.de>
Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/parport/parport_gsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/parport/parport_gsc.c b/drivers/parport/parport_gsc.c
index 5e4475254bd0..c7e18382dc01 100644
--- a/drivers/parport/parport_gsc.c
+++ b/drivers/parport/parport_gsc.c
@@ -392,7 +392,7 @@ static struct parisc_driver parport_driver __refdata = {
 	.remove		= __exit_p(parport_remove_chip),
 };
 
-int parport_gsc_init(void)
+static int parport_gsc_init(void)
 {
 	return register_parisc_driver(&parport_driver);
 }
-- 
2.39.2
Re: [PATCH 05/22] [RESEND] parport: gsc: mark init function static
Posted by Helge Deller 1 year, 10 months ago
On 11/8/23 13:58, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This is only used locally, so mark it static to avoid a warning:
>
> drivers/parport/parport_gsc.c:395:5: error: no previous prototype for 'parport_gsc_init' [-Werror=missing-prototypes]
>
> Acked-by: Helge Deller <deller@gmx.de>
> Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Since the parport_gsc driver is only used on parisc machines,
I've added this patch to the parisc git tree.

Thanks!
Helge


> ---
>   drivers/parport/parport_gsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/parport/parport_gsc.c b/drivers/parport/parport_gsc.c
> index 5e4475254bd0..c7e18382dc01 100644
> --- a/drivers/parport/parport_gsc.c
> +++ b/drivers/parport/parport_gsc.c
> @@ -392,7 +392,7 @@ static struct parisc_driver parport_driver __refdata = {
>   	.remove		= __exit_p(parport_remove_chip),
>   };
>
> -int parport_gsc_init(void)
> +static int parport_gsc_init(void)
>   {
>   	return register_parisc_driver(&parport_driver);
>   }