[PATCH] RISC-V: Remove __init on unaligned_emulation_finish()

Evan Green posted 1 patch 2 years, 1 month ago
arch/riscv/kernel/traps_misaligned.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] RISC-V: Remove __init on unaligned_emulation_finish()
Posted by Evan Green 2 years, 1 month ago
This function shouldn't be __init, since it's called during hotplug. The
warning says it well enough:

WARNING: modpost: vmlinux: section mismatch in reference:
check_unaligned_access_all_cpus+0x13a (section: .text) ->
unaligned_emulation_finish (section: .init.text)

Signed-off-by: Evan Green <evan@rivosinc.com>
Fixes: 71c54b3d169d ("riscv: report misaligned accesses emulation to hwprobe")

---

 arch/riscv/kernel/traps_misaligned.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps_misaligned.c
index bba301b5194d..5eba37147caa 100644
--- a/arch/riscv/kernel/traps_misaligned.c
+++ b/arch/riscv/kernel/traps_misaligned.c
@@ -625,7 +625,7 @@ bool check_unaligned_access_emulated(int cpu)
 	return misaligned_emu_detected;
 }
 
-void __init unaligned_emulation_finish(void)
+void unaligned_emulation_finish(void)
 {
 	int cpu;
 
-- 
2.34.1
Re: [PATCH] RISC-V: Remove __init on unaligned_emulation_finish()
Posted by patchwork-bot+linux-riscv@kernel.org 2 years, 1 month ago
Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Mon,  6 Nov 2023 15:11:05 -0800 you wrote:
> This function shouldn't be __init, since it's called during hotplug. The
> warning says it well enough:
> 
> WARNING: modpost: vmlinux: section mismatch in reference:
> check_unaligned_access_all_cpus+0x13a (section: .text) ->
> unaligned_emulation_finish (section: .init.text)
> 
> [...]

Here is the summary with links:
  - RISC-V: Remove __init on unaligned_emulation_finish()
    https://git.kernel.org/riscv/c/6eb7a6445b76

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html