include/linux/f2fs_fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
From: Yang Hubin <yanghb2019@lzu.edu.cn>
The macro SUMMARY_SIZE represents the size of the struct f2fs_summary,
instead of the size of the struct summary.
Signed-off-by: Yang Hubin <yanghb2019@lzu.edu.cn>
---
include/linux/f2fs_fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h
index 2ef6ad75edb6..e0e28fc53644 100644
--- a/include/linux/f2fs_fs.h
+++ b/include/linux/f2fs_fs.h
@@ -460,7 +460,7 @@ struct summary_footer {
#define NAT_JOURNAL_ENTRIES ((SUM_JOURNAL_SIZE - 2) /\
sizeof(struct nat_journal_entry))
#define NAT_JOURNAL_RESERVED ((SUM_JOURNAL_SIZE - 2) %\
- sizeof(struct nat_journal_entry))
+ sizeof(struct nat_journal_entry))SIT_JOURNA
#define SIT_JOURNAL_ENTRIES ((SUM_JOURNAL_SIZE - 2) /\
sizeof(struct sit_journal_entry))
#define SIT_JOURNAL_RESERVED ((SUM_JOURNAL_SIZE - 2) %\
--
2.25.1Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on jaegeuk-f2fs/dev-test]
[also build test ERROR on jaegeuk-f2fs/dev linus/master v6.6 next-20231107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/dslab-lzu-edu-cn/f2fs-the-name-of-a-struct-is-wrong-in-a-comment/20231106-201822
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
patch link: https://lore.kernel.org/r/20231106121418.3675-1-dslab%40lzu.edu.cn
patch subject: [PATCH] f2fs: the name of a struct is wrong in a comment.
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231108/202311080247.0hkA0mLH-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231108/202311080247.0hkA0mLH-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311080247.0hkA0mLH-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from fs/f2fs/dir.c:10:
>> include/linux/f2fs_fs.h:501:16: error: expected ']'
__u8 reserved[NAT_JOURNAL_RESERVED];
^
include/linux/f2fs_fs.h:474:38: note: expanded from macro 'NAT_JOURNAL_RESERVED'
sizeof(struct nat_journal_entry))SIT_JOURNA
^
include/linux/f2fs_fs.h:501:15: note: to match this '['
__u8 reserved[NAT_JOURNAL_RESERVED];
^
1 error generated.
vim +501 include/linux/f2fs_fs.h
dd31866b0d55c9 Jaegeuk Kim 2012-11-02 498
dd31866b0d55c9 Jaegeuk Kim 2012-11-02 499 struct nat_journal {
dd31866b0d55c9 Jaegeuk Kim 2012-11-02 500 struct nat_journal_entry entries[NAT_JOURNAL_ENTRIES];
dd31866b0d55c9 Jaegeuk Kim 2012-11-02 @501 __u8 reserved[NAT_JOURNAL_RESERVED];
dd31866b0d55c9 Jaegeuk Kim 2012-11-02 502 } __packed;
dd31866b0d55c9 Jaegeuk Kim 2012-11-02 503
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on jaegeuk-f2fs/dev-test]
[also build test ERROR on jaegeuk-f2fs/dev linus/master v6.6 next-20231107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/dslab-lzu-edu-cn/f2fs-the-name-of-a-struct-is-wrong-in-a-comment/20231106-201822
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
patch link: https://lore.kernel.org/r/20231106121418.3675-1-dslab%40lzu.edu.cn
patch subject: [PATCH] f2fs: the name of a struct is wrong in a comment.
config: parisc-randconfig-001-20231107 (https://download.01.org/0day-ci/archive/20231107/202311071353.SmED46lo-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231107/202311071353.SmED46lo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311071353.SmED46lo-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
In file included from fs/f2fs/segment.c:9:
>> include/linux/f2fs_fs.h:474:66: error: expected ']' before 'SIT_JOURNA'
474 | sizeof(struct nat_journal_entry))SIT_JOURNA
| ^~~~~~~~~~
include/linux/f2fs_fs.h:501:23: note: in expansion of macro 'NAT_JOURNAL_RESERVED'
501 | __u8 reserved[NAT_JOURNAL_RESERVED];
| ^~~~~~~~~~~~~~~~~~~~
>> include/linux/f2fs_fs.h:502:1: warning: no semicolon at end of struct or union
502 | } __packed;
| ^
vim +474 include/linux/f2fs_fs.h
468
469 #define SUM_JOURNAL_SIZE (F2FS_BLKSIZE - SUM_FOOTER_SIZE -\
470 SUM_ENTRY_SIZE)
471 #define NAT_JOURNAL_ENTRIES ((SUM_JOURNAL_SIZE - 2) /\
472 sizeof(struct nat_journal_entry))
473 #define NAT_JOURNAL_RESERVED ((SUM_JOURNAL_SIZE - 2) %\
> 474 sizeof(struct nat_journal_entry))SIT_JOURNA
475 #define SIT_JOURNAL_ENTRIES ((SUM_JOURNAL_SIZE - 2) /\
476 sizeof(struct sit_journal_entry))
477 #define SIT_JOURNAL_RESERVED ((SUM_JOURNAL_SIZE - 2) %\
478 sizeof(struct sit_journal_entry))
479
480 /* Reserved area should make size of f2fs_extra_info equals to
481 * that of nat_journal and sit_journal.
482 */
483 #define EXTRA_INFO_RESERVED (SUM_JOURNAL_SIZE - 2 - 8)
484
485 /*
486 * frequently updated NAT/SIT entries can be stored in the spare area in
487 * summary blocks
488 */
489 enum {
490 NAT_JOURNAL = 0,
491 SIT_JOURNAL
492 };
493
494 struct nat_journal_entry {
495 __le32 nid;
496 struct f2fs_nat_entry ne;
497 } __packed;
498
499 struct nat_journal {
500 struct nat_journal_entry entries[NAT_JOURNAL_ENTRIES];
501 __u8 reserved[NAT_JOURNAL_RESERVED];
> 502 } __packed;
503
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
© 2016 - 2025 Red Hat, Inc.