[PATCH 1/2] wifi: ath11k: Remove struct ath11k::ops

Jeff Johnson posted 2 patches 2 years, 1 month ago
[PATCH 1/2] wifi: ath11k: Remove struct ath11k::ops
Posted by Jeff Johnson 2 years, 1 month ago
Currently struct ath11k defines the following member:
        struct ieee80211_ops *ops;

This is being flagged by checkpatch.pl:
WARNING: struct ieee80211_ops should normally be const

The original plan was to add the const qualifier.  However, it turns
out this is actually unused, so remove it.

No functional changes, compile tested only.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/net/wireless/ath/ath11k/core.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.h b/drivers/net/wireless/ath/ath11k/core.h
index f12b606e2d2e..7e3b6779f4e9 100644
--- a/drivers/net/wireless/ath/ath11k/core.h
+++ b/drivers/net/wireless/ath/ath11k/core.h
@@ -599,7 +599,6 @@ struct ath11k {
 	struct ath11k_base *ab;
 	struct ath11k_pdev *pdev;
 	struct ieee80211_hw *hw;
-	struct ieee80211_ops *ops;
 	struct ath11k_pdev_wmi *wmi;
 	struct ath11k_pdev_dp dp;
 	u8 mac_addr[ETH_ALEN];

-- 
2.42.0
Re: [PATCH 1/2] wifi: ath11k: Remove struct ath11k::ops
Posted by Kalle Valo 2 years, 1 month ago
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:

> Currently struct ath11k defines the following member:
>         struct ieee80211_ops *ops;
> 
> This is being flagged by checkpatch.pl:
> WARNING: struct ieee80211_ops should normally be const
> 
> The original plan was to add the const qualifier.  However, it turns
> out this is actually unused, so remove it.
> 
> No functional changes, compile tested only.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

2 patches applied to ath-next branch of ath.git, thanks.

199a78565cc2 wifi: ath11k: Remove struct ath11k::ops
3b6ec0409fe8 wifi: ath12k: Remove struct ath12k::ops

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20231106-ath12k-remove-ieee80211_ops-v1-1-d72cef1a855b@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches