[PATCH 6/9] media: dt-bindings: rockchip,vdec: Add RK3288 compatible

Jonas Karlman posted 9 patches 2 years, 1 month ago
There is a newer version of this series
[PATCH 6/9] media: dt-bindings: rockchip,vdec: Add RK3288 compatible
Posted by Jonas Karlman 2 years, 1 month ago
Add a RK3288 compatible for a version of the Rockchip VDEC IP that only
support HEVC decoding.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
 Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
index 08b02ec16755..0f00e9c86737 100644
--- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
@@ -16,7 +16,9 @@ description: |-
 properties:
   compatible:
     oneOf:
-      - const: rockchip,rk3399-vdec
+      - enum:
+          - rockchip,rk3288-vdec
+          - rockchip,rk3399-vdec
       - items:
           - enum:
               - rockchip,rk3228-vdec
-- 
2.42.0
Re: [PATCH 6/9] media: dt-bindings: rockchip,vdec: Add RK3288 compatible
Posted by Conor Dooley 2 years, 1 month ago
On Sun, Nov 05, 2023 at 11:36:13PM +0000, Jonas Karlman wrote:
> Add a RK3288 compatible for a version of the Rockchip VDEC IP that only
> support HEVC decoding.
> 
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 08b02ec16755..0f00e9c86737 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -16,7 +16,9 @@ description: |-
>  properties:
>    compatible:
>      oneOf:
> -      - const: rockchip,rk3399-vdec
> +      - enum:
> +          - rockchip,rk3288-vdec
> +          - rockchip,rk3399-vdec
>        - items:
>            - enum:
>                - rockchip,rk3228-vdec
> -- 
> 2.42.0
> 
Re: [PATCH 6/9] media: dt-bindings: rockchip,vdec: Add RK3288 compatible
Posted by Heiko Stübner 1 year, 3 months ago
Hi Jonas,

Am Montag, 6. November 2023, 00:36:13 CEST schrieb Jonas Karlman:
> Add a RK3288 compatible for a version of the Rockchip VDEC IP that only
> support HEVC decoding.
> 
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>

While looking for something else in my inbox, I stumbled upon this series.
Looking at 6.12-rc1, it seems the rk3288 parts at least didn't make it in
yet, so I guess I a rebase+resend might be in order?


Heiko

> ---
>  Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 08b02ec16755..0f00e9c86737 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -16,7 +16,9 @@ description: |-
>  properties:
>    compatible:
>      oneOf:
> -      - const: rockchip,rk3399-vdec
> +      - enum:
> +          - rockchip,rk3288-vdec
> +          - rockchip,rk3399-vdec
>        - items:
>            - enum:
>                - rockchip,rk3228-vdec
>
Re: [PATCH 6/9] media: dt-bindings: rockchip,vdec: Add RK3288 compatible
Posted by Jonas Karlman 1 year, 3 months ago
Hi Heiko,

On 2024-09-30 16:46, Heiko Stübner wrote:
> Hi Jonas,
> 
> Am Montag, 6. November 2023, 00:36:13 CEST schrieb Jonas Karlman:
>> Add a RK3288 compatible for a version of the Rockchip VDEC IP that only
>> support HEVC decoding.
>>
>> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> 
> While looking for something else in my inbox, I stumbled upon this series.
> Looking at 6.12-rc1, it seems the rk3288 parts at least didn't make it in
> yet, so I guess I a rebase+resend might be in order?

Yes, this needs to be updated and resent, this series should still apply
clean on top of the dependent h264 high10 v6 series [1], however there
was some minor feedback to address in this series. Hoping to see some
progress on the h264 high10 v6 series and send an updated v2 of this
hevc series in near future.

Also trying to finish up a FFmpeg v4l2request hwaccel v3 series before I
take a closer look at a v2 of this rkvdec hevc series.

[1] https://lore.kernel.org/linux-media/20240909192522.1076704-1-jonas@kwiboo.se/

Regards,
Jonas

> 
> 
> Heiko
> 
>> ---
>>  Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>> index 08b02ec16755..0f00e9c86737 100644
>> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>> @@ -16,7 +16,9 @@ description: |-
>>  properties:
>>    compatible:
>>      oneOf:
>> -      - const: rockchip,rk3399-vdec
>> +      - enum:
>> +          - rockchip,rk3288-vdec
>> +          - rockchip,rk3399-vdec
>>        - items:
>>            - enum:
>>                - rockchip,rk3228-vdec
>>
> 
> 
> 
>