tools/testing/selftests/nolibc/nolibc-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Center-align all possible status reports.
Before OK and FAIL were center-aligned in relation to each other but
SKIPPED and FAILED would be left-aligned.
Before:
7 environ_addr = <0x7fffef3e7c50> [OK]
8 environ_envp = <0x7fffef3e7c58> [FAIL]
9 environ_auxv [SKIPPED]
10 environ_total [SKIPPED]
11 environ_HOME = <0x7fffef3e99bd> [OK]
12 auxv_addr [SKIPPED]
13 auxv_AT_UID = 1000 [OK]
After:
7 environ_addr = <0x7ffff13b00a0> [OK]
8 environ_envp = <0x7ffff13b00a8> [FAIL]
9 environ_auxv [SKIPPED]
10 environ_total [SKIPPED]
11 environ_HOME = <0x7ffff13b19bd> [OK]
12 auxv_addr [SKIPPED]
13 auxv_AT_UID = 1000 [OK]
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
tools/testing/selftests/nolibc/nolibc-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
index 2f10541e6f38..e173014f6b66 100644
--- a/tools/testing/selftests/nolibc/nolibc-test.c
+++ b/tools/testing/selftests/nolibc/nolibc-test.c
@@ -150,11 +150,11 @@ static void result(int llen, enum RESULT r)
const char *msg;
if (r == OK)
- msg = " [OK]";
+ msg = " [OK]";
else if (r == SKIPPED)
msg = "[SKIPPED]";
else
- msg = "[FAIL]";
+ msg = " [FAIL]";
if (llen < 64)
putcharn(' ', 64 - llen);
---
base-commit: 6de6466e41182875252fe09658f9b7d74c4fa43c
change-id: 20231105-nolibc-align-75992bdff544
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
On Sun, Nov 05, 2023 at 03:22:30PM +0100, Thomas Weißschuh wrote: > Center-align all possible status reports. > Before OK and FAIL were center-aligned in relation to each other but > SKIPPED and FAILED would be left-aligned. > > Before: > > 7 environ_addr = <0x7fffef3e7c50> [OK] > 8 environ_envp = <0x7fffef3e7c58> [FAIL] > 9 environ_auxv [SKIPPED] > 10 environ_total [SKIPPED] > 11 environ_HOME = <0x7fffef3e99bd> [OK] > 12 auxv_addr [SKIPPED] > 13 auxv_AT_UID = 1000 [OK] > > After: > > 7 environ_addr = <0x7ffff13b00a0> [OK] > 8 environ_envp = <0x7ffff13b00a8> [FAIL] > 9 environ_auxv [SKIPPED] > 10 environ_total [SKIPPED] > 11 environ_HOME = <0x7ffff13b19bd> [OK] > 12 auxv_addr [SKIPPED] > 13 auxv_AT_UID = 1000 [OK] > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Quite frankly for trivial cleanups like this you should not even bother with sending a review, and could queue them directly! Thanks, Willy
On 2023-11-05 15:27:00+0100, Willy Tarreau wrote: > On Sun, Nov 05, 2023 at 03:22:30PM +0100, Thomas Weißschuh wrote: > > Center-align all possible status reports. > > Before OK and FAIL were center-aligned in relation to each other but > > SKIPPED and FAILED would be left-aligned. > > > > Before: > > > > 7 environ_addr = <0x7fffef3e7c50> [OK] > > 8 environ_envp = <0x7fffef3e7c58> [FAIL] > > 9 environ_auxv [SKIPPED] > > 10 environ_total [SKIPPED] > > 11 environ_HOME = <0x7fffef3e99bd> [OK] > > 12 auxv_addr [SKIPPED] > > 13 auxv_AT_UID = 1000 [OK] > > > > After: > > > > 7 environ_addr = <0x7ffff13b00a0> [OK] > > 8 environ_envp = <0x7ffff13b00a8> [FAIL] > > 9 environ_auxv [SKIPPED] > > 10 environ_total [SKIPPED] > > 11 environ_HOME = <0x7ffff13b19bd> [OK] > > 12 auxv_addr [SKIPPED] > > 13 auxv_AT_UID = 1000 [OK] > > > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > > Quite frankly for trivial cleanups like this you should not even bother > with sending a review, and could queue them directly! Ok, will do! Thomas
© 2016 - 2025 Red Hat, Inc.