nfs: clean up some tracepoints in the lookup / revalidate codepaths

[PATCH 0/3] nfs: clean up some tracepoints in the lookup / revalidate codepaths

Posted by Jeff Layton 2 years, 1 month ago

I was looking at a lookupcache issue the other day that turned out to be
a false alarm. While looking I needed to turn up some tracepoints, and
found some of the info to be lacking. These patches just do a little
cleanup to the nfs tracepoints, and flesh them out a bit.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Jeff Layton (3):
      nfs: add new tracepoint at nfs4 revalidate entry point
      nfs: rename the nfs_async_rename_done tracepoint
      nfs: print fileid in lookup tracepoints

 fs/nfs/dir.c      |  2 ++
 fs/nfs/nfstrace.h | 16 +++++++++++-----
 fs/nfs/unlink.c   |  2 +-
 3 files changed, 14 insertions(+), 6 deletions(-)
---
base-commit: 21e80f3841c01aeaf32d7aee7bbc87b3db1aa0c6
change-id: 20231102-nfs-6-8-7a98e3e480d2

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH 0/3] nfs: clean up some tracepoints in the lookup / revalidate codepaths

Posted by Chuck Lever III 2 years, 1 month ago


> On Nov 3, 2023, at 3:10 AM, Jeff Layton <jlayton@kernel.org> wrote:
> 
> I was looking at a lookupcache issue the other day that turned out to be
> a false alarm. While looking I needed to turn up some tracepoints, and
> found some of the info to be lacking. These patches just do a little
> cleanup to the nfs tracepoints, and flesh them out a bit.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com <mailto:chuck.lever@oracle.com>>


> ---
> Jeff Layton (3):
>      nfs: add new tracepoint at nfs4 revalidate entry point
>      nfs: rename the nfs_async_rename_done tracepoint
>      nfs: print fileid in lookup tracepoints
> 
> fs/nfs/dir.c      |  2 ++
> fs/nfs/nfstrace.h | 16 +++++++++++-----
> fs/nfs/unlink.c   |  2 +-
> 3 files changed, 14 insertions(+), 6 deletions(-)
> ---
> base-commit: 21e80f3841c01aeaf32d7aee7bbc87b3db1aa0c6
> change-id: 20231102-nfs-6-8-7a98e3e480d2
> 
> Best regards,
> -- 
> Jeff Layton <jlayton@kernel.org>
> 

--
Chuck Lever