[PATCH v3 1/2] ASoC: dt-bindings: nau8821: Add DMIC slew rate

Seven Lee posted 2 patches 2 years, 1 month ago
There is a newer version of this series
[PATCH v3 1/2] ASoC: dt-bindings: nau8821: Add DMIC slew rate
Posted by Seven Lee 2 years, 1 month ago
Add input with DMIC slew rate controls

Signed-off-by: Seven Lee <wtli@nuvoton.com>
---
 .../devicetree/bindings/sound/nuvoton,nau8821.yaml        | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
index 3e54abd4ca74..48c389276a15 100644
--- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
+++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
@@ -89,6 +89,13 @@ properties:
     $ref: /schemas/types.yaml#/definitions/uint32
     default: 3072000
 
+  nuvoton,dmic-slew-rate:
+    description: The range 0 to 7 represents the speed of DMIC slew rate.
+        The lowest value 0 means the slowest rate and the highest value
+        7 means the fastest rate.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    default: 0
+
   nuvoton,left-input-single-end:
     description: Enable left input with single-ended settings if set.
         For the headset mic application, the single-ended control is
@@ -127,6 +134,7 @@ examples:
             nuvoton,jack-insert-debounce = <7>;
             nuvoton,jack-eject-debounce = <0>;
             nuvoton,dmic-clk-threshold = <3072000>;
+            nuvoton,dmic-slew-rate= <0>;
             #sound-dai-cells = <0>;
         };
     };
-- 
2.25.1
Re: [PATCH v3 1/2] ASoC: dt-bindings: nau8821: Add DMIC slew rate
Posted by Rob Herring 2 years, 1 month ago
On Wed, Nov 01, 2023 at 02:35:13PM +0800, Seven Lee wrote:
> Add input with DMIC slew rate controls
> 
> Signed-off-by: Seven Lee <wtli@nuvoton.com>
> ---
>  .../devicetree/bindings/sound/nuvoton,nau8821.yaml        | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> index 3e54abd4ca74..48c389276a15 100644
> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> @@ -89,6 +89,13 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      default: 3072000
>  
> +  nuvoton,dmic-slew-rate:
> +    description: The range 0 to 7 represents the speed of DMIC slew rate.
> +        The lowest value 0 means the slowest rate and the highest value
> +        7 means the fastest rate.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    default: 0

Don't write constraints in prose:

maximum: 7

> +
>    nuvoton,left-input-single-end:
>      description: Enable left input with single-ended settings if set.
>          For the headset mic application, the single-ended control is
> @@ -127,6 +134,7 @@ examples:
>              nuvoton,jack-insert-debounce = <7>;
>              nuvoton,jack-eject-debounce = <0>;
>              nuvoton,dmic-clk-threshold = <3072000>;
> +            nuvoton,dmic-slew-rate= <0>;
>              #sound-dai-cells = <0>;
>          };
>      };
> -- 
> 2.25.1
>
Re: [PATCH v3 1/2] ASoC: dt-bindings: nau8821: Add DMIC slew rate
Posted by AS50 WTLi 2 years, 1 month ago
On 11/6/2023 10:41 PM, Rob Herring wrote:
> CAUTION - External Email: Do not click links or open attachments unless you acknowledge the sender and content.
>
>
> On Wed, Nov 01, 2023 at 02:35:13PM +0800, Seven Lee wrote:
>> Add input with DMIC slew rate controls
>>
>> Signed-off-by: Seven Lee <wtli@nuvoton.com>
>> ---
>>   .../devicetree/bindings/sound/nuvoton,nau8821.yaml        | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> index 3e54abd4ca74..48c389276a15 100644
>> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> @@ -89,6 +89,13 @@ properties:
>>       $ref: /schemas/types.yaml#/definitions/uint32
>>       default: 3072000
>>
>> +  nuvoton,dmic-slew-rate:
>> +    description: The range 0 to 7 represents the speed of DMIC slew rate.
>> +        The lowest value 0 means the slowest rate and the highest value
>> +        7 means the fastest rate.
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    default: 0
> Don't write constraints in prose:
>
> maximum: 7

okay, I will add maximum: 7 description. Thanks.

>
>> +
>>     nuvoton,left-input-single-end:
>>       description: Enable left input with single-ended settings if set.
>>           For the headset mic application, the single-ended control is
>> @@ -127,6 +134,7 @@ examples:
>>               nuvoton,jack-insert-debounce = <7>;
>>               nuvoton,jack-eject-debounce = <0>;
>>               nuvoton,dmic-clk-threshold = <3072000>;
>> +            nuvoton,dmic-slew-rate= <0>;
>>               #sound-dai-cells = <0>;
>>           };
>>       };
>> --
>> 2.25.1
>>
________________________________
________________________________
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.