[PATCH] optee: add missing description of RPC argument reference

Etienne Carriere posted 1 patch 2 years, 2 months ago
drivers/tee/optee/smc_abi.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] optee: add missing description of RPC argument reference
Posted by Etienne Carriere 2 years, 2 months ago
Adds missing inline description comment for RPC optional arguments
reference.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/lkml/202310192021.fvb6JDOY-lkp@intel.com/
Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>
---
 drivers/tee/optee/smc_abi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tee/optee/smc_abi.c b/drivers/tee/optee/smc_abi.c
index d5b28fd35d66..67bfa25d6302 100644
--- a/drivers/tee/optee/smc_abi.c
+++ b/drivers/tee/optee/smc_abi.c
@@ -806,6 +806,7 @@ static void handle_rpc_func_cmd(struct tee_context *ctx, struct optee *optee,
 /**
  * optee_handle_rpc() - handle RPC from secure world
  * @ctx:	context doing the RPC
+ * @rpc_arg:	pointer to RPC arguments if any, or NULL if none
  * @param:	value of registers for the RPC
  * @call_ctx:	call context. Preserved during one OP-TEE invocation
  *
-- 
2.25.1
Re: [PATCH] optee: add missing description of RPC argument reference
Posted by Sumit Garg 2 years, 2 months ago
On Mon, 30 Oct 2023 at 14:25, Etienne Carriere
<etienne.carriere@foss.st.com> wrote:
>
> Adds missing inline description comment for RPC optional arguments
> reference.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/lkml/202310192021.fvb6JDOY-lkp@intel.com/
> Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>
> ---
>  drivers/tee/optee/smc_abi.c | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

-Sumit

> diff --git a/drivers/tee/optee/smc_abi.c b/drivers/tee/optee/smc_abi.c
> index d5b28fd35d66..67bfa25d6302 100644
> --- a/drivers/tee/optee/smc_abi.c
> +++ b/drivers/tee/optee/smc_abi.c
> @@ -806,6 +806,7 @@ static void handle_rpc_func_cmd(struct tee_context *ctx, struct optee *optee,
>  /**
>   * optee_handle_rpc() - handle RPC from secure world
>   * @ctx:       context doing the RPC
> + * @rpc_arg:   pointer to RPC arguments if any, or NULL if none
>   * @param:     value of registers for the RPC
>   * @call_ctx:  call context. Preserved during one OP-TEE invocation
>   *
> --
> 2.25.1
>
Re: [PATCH] optee: add missing description of RPC argument reference
Posted by Jens Wiklander 2 years, 1 month ago
On Mon, Oct 30, 2023 at 10:06 AM Sumit Garg <sumit.garg@linaro.org> wrote:
>
> On Mon, 30 Oct 2023 at 14:25, Etienne Carriere
> <etienne.carriere@foss.st.com> wrote:
> >
> > Adds missing inline description comment for RPC optional arguments
> > reference.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/lkml/202310192021.fvb6JDOY-lkp@intel.com/
> > Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>
> > ---
> >  drivers/tee/optee/smc_abi.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
>
> Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

I'm picking up this.

Thanks,
Jens

>
> -Sumit
>
> > diff --git a/drivers/tee/optee/smc_abi.c b/drivers/tee/optee/smc_abi.c
> > index d5b28fd35d66..67bfa25d6302 100644
> > --- a/drivers/tee/optee/smc_abi.c
> > +++ b/drivers/tee/optee/smc_abi.c
> > @@ -806,6 +806,7 @@ static void handle_rpc_func_cmd(struct tee_context *ctx, struct optee *optee,
> >  /**
> >   * optee_handle_rpc() - handle RPC from secure world
> >   * @ctx:       context doing the RPC
> > + * @rpc_arg:   pointer to RPC arguments if any, or NULL if none
> >   * @param:     value of registers for the RPC
> >   * @call_ctx:  call context. Preserved during one OP-TEE invocation
> >   *
> > --
> > 2.25.1
> >