power: swap: Assign a value when removing the 'error' definition

[PATCH] power: swap: Assign a value when removing the 'error' definition

Posted by Li zeming 2 years, 1 month ago

'error' first receives the function result before it is used, and it
does not need to be assigned a value during definition.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 kernel/power/swap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/power/swap.c b/kernel/power/swap.c
index 74edbce2320ba..90bb583c57bf7 100644
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -450,7 +450,7 @@ static int get_swap_writer(struct swap_map_handle *handle)
 static int swap_write_page(struct swap_map_handle *handle, void *buf,
 		struct hib_bio_batch *hb)
 {
-	int error = 0;
+	int error;
 	sector_t offset;
 
 	if (!handle->cur)
-- 
2.18.2

Re: [PATCH] power: swap: Assign a value when removing the 'error' definition

Posted by Rafael J. Wysocki 2 years ago

On Fri, Oct 27, 2023 at 3:56 AM Li zeming <zeming@nfschina.com> wrote:
>
> 'error' first receives the function result before it is used, and it
> does not need to be assigned a value during definition.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  kernel/power/swap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/swap.c b/kernel/power/swap.c
> index 74edbce2320ba..90bb583c57bf7 100644
> --- a/kernel/power/swap.c
> +++ b/kernel/power/swap.c
> @@ -450,7 +450,7 @@ static int get_swap_writer(struct swap_map_handle *handle)
>  static int swap_write_page(struct swap_map_handle *handle, void *buf,
>                 struct hib_bio_batch *hb)
>  {
> -       int error = 0;
> +       int error;
>         sector_t offset;
>
>         if (!handle->cur)
> --

Applied as 6.8 material under a rewritten subject.

Thanks!