i40e: Remove AQ register definitions for VF types

[PATCH iwl-next] i40e: Remove AQ register definitions for VF types

Posted by Ivan Vecera 2 years, 1 month ago

The i40e driver does not handle its VF device types so there
is no need to keep AdminQ register definitions for such
device types. Remove them.

Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
 drivers/net/ethernet/intel/i40e/i40e_register.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_register.h b/drivers/net/ethernet/intel/i40e/i40e_register.h
index d561687303ea..2e1eaca44343 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_register.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_register.h
@@ -863,16 +863,6 @@
 #define I40E_PFPM_WUFC 0x0006B400 /* Reset: POR */
 #define I40E_PFPM_WUFC_MAG_SHIFT 1
 #define I40E_PFPM_WUFC_MAG_MASK I40E_MASK(0x1, I40E_PFPM_WUFC_MAG_SHIFT)
-#define I40E_VF_ARQBAH1 0x00006000 /* Reset: EMPR */
-#define I40E_VF_ARQBAL1 0x00006C00 /* Reset: EMPR */
-#define I40E_VF_ARQH1 0x00007400 /* Reset: EMPR */
-#define I40E_VF_ARQLEN1 0x00008000 /* Reset: EMPR */
-#define I40E_VF_ARQT1 0x00007000 /* Reset: EMPR */
-#define I40E_VF_ATQBAH1 0x00007800 /* Reset: EMPR */
-#define I40E_VF_ATQBAL1 0x00007C00 /* Reset: EMPR */
-#define I40E_VF_ATQH1 0x00006400 /* Reset: EMPR */
-#define I40E_VF_ATQLEN1 0x00006800 /* Reset: EMPR */
-#define I40E_VF_ATQT1 0x00008400 /* Reset: EMPR */
 #define I40E_VFQF_HLUT_MAX_INDEX 15
 
 
-- 
2.41.0

Re: [PATCH iwl-next] i40e: Remove AQ register definitions for VF types

Posted by Simon Horman 2 years, 1 month ago

On Thu, Oct 26, 2023 at 10:38:22AM +0200, Ivan Vecera wrote:
> The i40e driver does not handle its VF device types so there
> is no need to keep AdminQ register definitions for such
> device types. Remove them.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Thanks, another nice cleanup.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH iwl-next] i40e: Remove AQ register definitions for VF types

Posted by Wojciech Drewek 2 years, 1 month ago


On 26.10.2023 10:38, Ivan Vecera wrote:
> The i40e driver does not handle its VF device types so there
> is no need to keep AdminQ register definitions for such
> device types. Remove them.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---

Thanks Ivan!
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  drivers/net/ethernet/intel/i40e/i40e_register.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_register.h b/drivers/net/ethernet/intel/i40e/i40e_register.h
> index d561687303ea..2e1eaca44343 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_register.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_register.h
> @@ -863,16 +863,6 @@
>  #define I40E_PFPM_WUFC 0x0006B400 /* Reset: POR */
>  #define I40E_PFPM_WUFC_MAG_SHIFT 1
>  #define I40E_PFPM_WUFC_MAG_MASK I40E_MASK(0x1, I40E_PFPM_WUFC_MAG_SHIFT)
> -#define I40E_VF_ARQBAH1 0x00006000 /* Reset: EMPR */
> -#define I40E_VF_ARQBAL1 0x00006C00 /* Reset: EMPR */
> -#define I40E_VF_ARQH1 0x00007400 /* Reset: EMPR */
> -#define I40E_VF_ARQLEN1 0x00008000 /* Reset: EMPR */
> -#define I40E_VF_ARQT1 0x00007000 /* Reset: EMPR */
> -#define I40E_VF_ATQBAH1 0x00007800 /* Reset: EMPR */
> -#define I40E_VF_ATQBAL1 0x00007C00 /* Reset: EMPR */
> -#define I40E_VF_ATQH1 0x00006400 /* Reset: EMPR */
> -#define I40E_VF_ATQLEN1 0x00006800 /* Reset: EMPR */
> -#define I40E_VF_ATQT1 0x00008400 /* Reset: EMPR */
>  #define I40E_VFQF_HLUT_MAX_INDEX 15
>  
>

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Remove AQ register definitions for VF types

Posted by Przemek Kitszel 2 years, 1 month ago

On 10/26/23 10:38, Ivan Vecera wrote:
> The i40e driver does not handle its VF device types so there
> is no need to keep AdminQ register definitions for such
> device types. Remove them.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_register.h | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_register.h b/drivers/net/ethernet/intel/i40e/i40e_register.h
> index d561687303ea..2e1eaca44343 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_register.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_register.h
> @@ -863,16 +863,6 @@
>   #define I40E_PFPM_WUFC 0x0006B400 /* Reset: POR */
>   #define I40E_PFPM_WUFC_MAG_SHIFT 1
>   #define I40E_PFPM_WUFC_MAG_MASK I40E_MASK(0x1, I40E_PFPM_WUFC_MAG_SHIFT)
> -#define I40E_VF_ARQBAH1 0x00006000 /* Reset: EMPR */
> -#define I40E_VF_ARQBAL1 0x00006C00 /* Reset: EMPR */
> -#define I40E_VF_ARQH1 0x00007400 /* Reset: EMPR */
> -#define I40E_VF_ARQLEN1 0x00008000 /* Reset: EMPR */
> -#define I40E_VF_ARQT1 0x00007000 /* Reset: EMPR */
> -#define I40E_VF_ATQBAH1 0x00007800 /* Reset: EMPR */
> -#define I40E_VF_ATQBAL1 0x00007C00 /* Reset: EMPR */
> -#define I40E_VF_ATQH1 0x00006400 /* Reset: EMPR */
> -#define I40E_VF_ATQLEN1 0x00006800 /* Reset: EMPR */
> -#define I40E_VF_ATQT1 0x00008400 /* Reset: EMPR */
>   #define I40E_VFQF_HLUT_MAX_INDEX 15
>   
>   

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>