[PATCH v3 0/3] nvme-tcp: always set valid seq_num in dhchap reply

Mark O'Donovan posted 3 patches 2 years, 1 month ago
drivers/nvme/host/auth.c               | 13 ++++++-------
drivers/nvme/target/fabrics-cmd-auth.c |  2 +-
include/linux/nvme.h                   |  2 +-
3 files changed, 8 insertions(+), 9 deletions(-)
[PATCH v3 0/3] nvme-tcp: always set valid seq_num in dhchap reply
Posted by Mark O'Donovan 2 years, 1 month ago
The first patch is a small unrelated fix which makes it clear that the
response data section of the Success1 message is not optional.

The second patch removes use of the host sequence number (S2) as an
indicator of bi-directional authentication.

The third patch causes us to always set the host sequence number (S2)
to a non-zero value instead of the 0 value reserved for the secure
channel feature.

v1: original submission
v2: rebased + added dedicated variable for bi-directional auth
v3: nvme-target code now reads seq-num

Mark O'Donovan (3):
  nvme-auth: auth success1 msg always includes resp
  nvme-auth: add flag for bi-directional auth
  nvme-auth: always set valid seq_num in dhchap reply

 drivers/nvme/host/auth.c               | 13 ++++++-------
 drivers/nvme/target/fabrics-cmd-auth.c |  2 +-
 include/linux/nvme.h                   |  2 +-
 3 files changed, 8 insertions(+), 9 deletions(-)


base-commit: 4f82870119a46b0d04d91ef4697ac4977a255a9d
-- 
2.39.2
Re: [PATCH v3 0/3] nvme-tcp: always set valid seq_num in dhchap reply
Posted by Keith Busch 2 years, 1 month ago
On Wed, Oct 25, 2023 at 10:51:22AM +0000, Mark O'Donovan wrote:
> The first patch is a small unrelated fix which makes it clear that the
> response data section of the Success1 message is not optional.
> 
> The second patch removes use of the host sequence number (S2) as an
> indicator of bi-directional authentication.
> 
> The third patch causes us to always set the host sequence number (S2)
> to a non-zero value instead of the 0 value reserved for the secure
> channel feature.

Thanks, queued up for nvme-6.7.