[v1] dt-bindings: usb: qcom,dwc3: document the SM8560 SuperSpeed DWC3 USB controller

[PATCH] dt-bindings: usb: qcom,dwc3: document the SM8560 SuperSpeed DWC3 USB controller

Posted by Neil Armstrong 2 years, 2 months ago

Document the SuperSpeed DWC3 USB controller on the SM8650 Platform.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
For convenience, a regularly refreshed linux-next based git tree containing
all the SM8650 related work is available at:
https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm85650/upstream/integ
---
 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index e889158ca205..ea2c663ddc52 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -46,6 +46,7 @@ properties:
           - qcom,sm8350-dwc3
           - qcom,sm8450-dwc3
           - qcom,sm8550-dwc3
+          - qcom,sm8650-dwc3
       - const: qcom,dwc3
 
   reg:

---
base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
change-id: 20231016-topic-sm8650-upstream-bindings-dwc3-6e421941f9ff

Best regards,
-- 
Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH] dt-bindings: usb: qcom,dwc3: document the SM8560 SuperSpeed DWC3 USB controller

Posted by Krzysztof Kozlowski 2 years, 2 months ago

On 25/10/2023 09:25, Neil Armstrong wrote:
> Document the SuperSpeed DWC3 USB controller on the SM8650 Platform.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> For convenience, a regularly refreshed linux-next based git tree containing
> all the SM8650 related work is available at:
> https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm85650/upstream/integ
> ---
>  Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> index e889158ca205..ea2c663ddc52 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> @@ -46,6 +46,7 @@ properties:
>            - qcom,sm8350-dwc3
>            - qcom,sm8450-dwc3
>            - qcom,sm8550-dwc3
> +          - qcom,sm8650-dwc3
>        - const: qcom,dwc3

I think you miss two dedicated entries in allOf:if:then for clocks and
interrupts.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: usb: qcom,dwc3: document the SM8560 SuperSpeed DWC3 USB controller

Posted by Mukesh Ojha 2 years, 2 months ago


On 10/25/2023 1:37 PM, Krzysztof Kozlowski wrote:
> On 25/10/2023 09:25, Neil Armstrong wrote:
>> Document the SuperSpeed DWC3 USB controller on the SM8650 Platform.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

Typo here as well, sm8650.

>> ---
>> For convenience, a regularly refreshed linux-next based git tree containing
>> all the SM8650 related work is available at:
>> https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm85650/upstream/integ
>> ---
>>   Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
>> index e889158ca205..ea2c663ddc52 100644
>> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
>> @@ -46,6 +46,7 @@ properties:
>>             - qcom,sm8350-dwc3
>>             - qcom,sm8450-dwc3
>>             - qcom,sm8550-dwc3
>> +          - qcom,sm8650-dwc3
>>         - const: qcom,dwc3
> 
> I think you miss two dedicated entries in allOf:if:then for clocks and
> interrupts.
> 
> Best regards,
> Krzysztof
>