arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node

[PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node

Posted by Kathiravan Thirumoorthy 2 years, 1 month ago

Add the color and function property to the GPIO LED node, which are
missed out in the initial submission.

Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
---
 arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
index 4870cdb764d0..b37ae7749083 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
@@ -9,6 +9,7 @@
 
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
 #include "ipq5332.dtsi"
 
 / {
@@ -39,6 +40,8 @@ leds {
 		pinctrl-names = "default";
 
 		led-0 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_WLAN;
 			gpios = <&tlmm 36 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "phy0tx";
 			default-state = "off";

---
base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
change-id: 20231025-ipq5332-gpio-led-cd157e81d7b0

Best regards,
-- 
Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>

Re: [PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node

Posted by Bjorn Andersson 2 years ago

On Wed, 25 Oct 2023 19:20:05 +0530, Kathiravan Thirumoorthy wrote:
> Add the color and function property to the GPIO LED node, which are
> missed out in the initial submission.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node
      commit: 63a021f52f69092f17d24707cd8e81f914f8d1e6

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node

Posted by Kathiravan Thirumoorthy 2 years ago


On 10/25/2023 7:20 PM, Kathiravan Thirumoorthy wrote:
> Add the color and function property to the GPIO LED node, which are
> missed out in the initial submission.
> 


Gentle Reminder...


> Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
> ---
>   arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
> index 4870cdb764d0..b37ae7749083 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
> @@ -9,6 +9,7 @@
>   
>   #include <dt-bindings/gpio/gpio.h>
>   #include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
>   #include "ipq5332.dtsi"
>   
>   / {
> @@ -39,6 +40,8 @@ leds {
>   		pinctrl-names = "default";
>   
>   		led-0 {
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_WLAN;
>   			gpios = <&tlmm 36 GPIO_ACTIVE_HIGH>;
>   			linux,default-trigger = "phy0tx";
>   			default-state = "off";
> 
> ---
> base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
> change-id: 20231025-ipq5332-gpio-led-cd157e81d7b0
> 
> Best regards,

Re: [PATCH] arm64: dts: qcom: ipq5332: add missing properties to the GPIO LED node

Posted by Krzysztof Kozlowski 2 years, 1 month ago

On 25/10/2023 15:50, Kathiravan Thirumoorthy wrote:
> Add the color and function property to the GPIO LED node, which are
> missed out in the initial submission.
> 
> Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof