[PATCH net-next v2 1/4] octeon_ep: add padding for small packets

Shinas Rasheed posted 4 patches 2 years, 2 months ago
There is a newer version of this series
[PATCH net-next v2 1/4] octeon_ep: add padding for small packets
Posted by Shinas Rasheed 2 years, 2 months ago
Pad small packets to ETH_ZLEN before transmit.

Signed-off-by: Shinas Rasheed <srasheed@marvell.com>
---
V1->V2:
   - New patch

 drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
index 552970c7dec0..2c86b911a380 100644
--- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
@@ -820,6 +820,9 @@ static netdev_tx_t octep_start_xmit(struct sk_buff *skb,
 	u16 nr_frags, si;
 	u16 q_no, wi;
 
+	if (skb_put_padto(skb, ETH_ZLEN))
+		return NETDEV_TX_OK;
+
 	q_no = skb_get_queue_mapping(skb);
 	if (q_no >= oct->num_iqs) {
 		netdev_err(netdev, "Invalid Tx skb->queue_mapping=%d\n", q_no);
-- 
2.25.1
Re: [PATCH net-next v2 1/4] octeon_ep: add padding for small packets
Posted by Jakub Kicinski 2 years, 2 months ago
On Tue, 24 Oct 2023 07:51:16 -0700 Shinas Rasheed wrote:
> Pad small packets to ETH_ZLEN before transmit.

The commit message needs to focus on the "why", rather than "what".
-- 
pw-bot: cr