power: snapshot: Optimize the error variable in the snapshot_write_next()

[PATCH] power: snapshot: Optimize the error variable in the snapshot_write_next()

Posted by Li zeming 2 years, 2 months ago

Assign a value when removing the definition for error, which is assigned
before use.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 kernel/power/snapshot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index 87e9f7e2bdc05..40c141144c9a1 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -2776,7 +2776,7 @@ static void *get_buffer(struct memory_bitmap *bm, struct chain_allocator *ca)
 int snapshot_write_next(struct snapshot_handle *handle)
 {
 	static struct chain_allocator ca;
-	int error = 0;
+	int error;
 
 next:
 	/* Check if we have already loaded the entire image */
-- 
2.18.2

Re: [PATCH] power: snapshot: Optimize the error variable in the snapshot_write_next()

Posted by Rafael J. Wysocki 2 years ago

On Tue, Oct 24, 2023 at 4:05 AM Li zeming <zeming@nfschina.com> wrote:
>
> Assign a value when removing the definition for error, which is assigned
> before use.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  kernel/power/snapshot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
> index 87e9f7e2bdc05..40c141144c9a1 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -2776,7 +2776,7 @@ static void *get_buffer(struct memory_bitmap *bm, struct chain_allocator *ca)
>  int snapshot_write_next(struct snapshot_handle *handle)
>  {
>         static struct chain_allocator ca;
> -       int error = 0;
> +       int error;
>
>  next:
>         /* Check if we have already loaded the entire image */
> --

Applied as 6.8 material with rewritten subject and changelog.

Thanks!