staging: media: av7110: Fix various formatting and small code issues

[PATCH 0/5] staging: media: av7110: Fix various formatting and small code issues

Posted by Jonathan Bergh 2 years, 1 month ago

These patches cover various formatting and small code issues. Formatting
issues include missing newlines, whitespace and miscellaneous formatting 
issues. The series also fixes small code issues including using preferred 
integer types ('long' instead of 'long int') and ('unsigned int' instead 
of 'unsigned').

Jonathan Bergh (5):
  staging: media: av7110: Fix missing newlines after declaration
    warnings
  staging: media: av7110: Fix various whitespace checkpatch errors
  staging: media: av7110: Remove unnecessary whitespace before quoted
    newlines
  staging: media: av7110: Fix 'long int' and 'unsigned' variable
    declarations
  staging: media: av7110: Fix various formating issues

 drivers/staging/media/av7110/av7110_av.c | 114 +++++++++++++----------
 1 file changed, 64 insertions(+), 50 deletions(-)

-- 
2.40.1

Re: [PATCH 0/5] staging: media: av7110: Fix various formatting and small code issues

Posted by Hans Verkuil 2 years ago

Hi Jonathan,

On 21/10/2023 01:23, Jonathan Bergh wrote:
> These patches cover various formatting and small code issues. Formatting
> issues include missing newlines, whitespace and miscellaneous formatting 
> issues. The series also fixes small code issues including using preferred 
> integer types ('long' instead of 'long int') and ('unsigned int' instead 
> of 'unsigned').
> 
> Jonathan Bergh (5):
>   staging: media: av7110: Fix missing newlines after declaration
>     warnings
>   staging: media: av7110: Fix various whitespace checkpatch errors
>   staging: media: av7110: Remove unnecessary whitespace before quoted
>     newlines
>   staging: media: av7110: Fix 'long int' and 'unsigned' variable
>     declarations
>   staging: media: av7110: Fix various formating issues
> 
>  drivers/staging/media/av7110/av7110_av.c | 114 +++++++++++++----------
>  1 file changed, 64 insertions(+), 50 deletions(-)
> 

For future reference: when looking at staging drivers always check the
TODO file. In this case see drivers/staging/media/av7110/TODO:

- This driver is too old and relies on a different API.
  Drop it from Kernel on a couple of versions.
- Cleanup patches for the drivers here won't be accepted.

So I'll just drop these cleanup patches.

Regards,

	Hans