[PATCH] arm64: dts: qcom: msm8916-acer-a1-724: Add notification LED

Raymond Hackley posted 1 patch 2 years, 3 months ago
.../boot/dts/qcom/msm8916-acer-a1-724.dts     | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
[PATCH] arm64: dts: qcom: msm8916-acer-a1-724: Add notification LED
Posted by Raymond Hackley 2 years, 3 months ago
Acer Iconia Talk S A1-724 uses KTD2026 LED driver. However, there is
no blue LED on it. Add it to the device tree.

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
 .../boot/dts/qcom/msm8916-acer-a1-724.dts     | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts b/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts
index 84723c9b73b4..b0f0f9f59cb3 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts
@@ -7,6 +7,7 @@
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
 #include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/leds/common.h>
 
 /*
  * NOTE: The original firmware from Acer can only boot 32-bit kernels.
@@ -83,6 +84,29 @@ magnetometer@12 {
 	};
 };
 
+&blsp_i2c4 {
+	status = "okay";
+
+	led-controller@30 {
+		compatible = "kinetic,ktd2026";
+		reg = <0x30>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@0 {
+			reg = <0>;
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		led@1 {
+			reg = <1>;
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+	};
+};
+
 &blsp_i2c5 {
 	status = "okay";
 
-- 
2.39.2
Re: [PATCH] arm64: dts: qcom: msm8916-acer-a1-724: Add notification LED
Posted by Bjorn Andersson 2 years, 2 months ago
On Tue, 17 Oct 2023 13:00:11 +0000, Raymond Hackley wrote:
> Acer Iconia Talk S A1-724 uses KTD2026 LED driver. However, there is
> no blue LED on it. Add it to the device tree.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: msm8916-acer-a1-724: Add notification LED
      commit: 50891bc7f1e9e65fa260c442efa7fa24b3523c96

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH] arm64: dts: qcom: msm8916-acer-a1-724: Add notification LED
Posted by Konrad Dybcio 2 years, 3 months ago

On 10/17/23 15:00, Raymond Hackley wrote:
> Acer Iconia Talk S A1-724 uses KTD2026 LED driver. However, there is
> no blue LED on it.
what

that's probably $0.00002 saved..

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad