[PATCH] sched: topology: Remove unnecessary ‘0’ values from nr_levels

Li kunyu posted 1 patch 2 years, 2 months ago
kernel/sched/topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] sched: topology: Remove unnecessary ‘0’ values from nr_levels
Posted by Li kunyu 2 years, 2 months ago
nr_levels is assigned first, so it does not need to initialize the
assignment.

Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
 kernel/sched/topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 05a5bc678c089..0ead4e72bc6ca 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1823,7 +1823,7 @@ void sched_init_numa(int offline_node)
 {
 	struct sched_domain_topology_level *tl;
 	unsigned long *distance_map;
-	int nr_levels = 0;
+	int nr_levels;
 	int i, j;
 	int *distances;
 	struct cpumask ***masks;
-- 
2.18.2
Re: [PATCH] sched: topology: Remove unnecessary ‘0’ values from nr_levels
Posted by Ingo Molnar 2 years, 1 month ago
* Li kunyu <kunyu@nfschina.com> wrote:

> nr_levels is assigned first, so it does not need to initialize the
> assignment.

In C there's no such thing as "initializing the assignment"...

Please write sensible changelogs that demonstrate an understanding of these 
principles.

Thanks,

	Ingo