[PATCH] platform/x86: asus-laptop: remove redundant braces in if statements

Edson Juliano Drosdeck posted 1 patch 2 years, 2 months ago
drivers/platform/x86/asus-laptop.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] platform/x86: asus-laptop: remove redundant braces in if statements
Posted by Edson Juliano Drosdeck 2 years, 2 months ago
Adhere to Linux kernel coding style.

Reported by checkpatch:

WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
---
 drivers/platform/x86/asus-laptop.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index 761029f39314..bf03ea1b1274 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -1816,9 +1816,8 @@ static void asus_dmi_check(void)
 		return;
 
 	/* On L1400B WLED control the sound card, don't mess with it ... */
-	if (strncmp(model, "L1400B", 6) == 0) {
+	if (strncmp(model, "L1400B", 6) == 0)
 		wlan_status = -1;
-	}
 }
 
 static bool asus_device_present;
-- 
2.39.2
Re: [PATCH] platform/x86: asus-laptop: remove redundant braces in if statements
Posted by Hans de Goede 2 years ago
Hi,

On 10/16/23 21:13, Edson Juliano Drosdeck wrote:
> Adhere to Linux kernel coding style.
> 
> Reported by checkpatch:
> 
> WARNING: braces {} are not necessary for single statement blocks
> 
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans




> ---
>  drivers/platform/x86/asus-laptop.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 761029f39314..bf03ea1b1274 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -1816,9 +1816,8 @@ static void asus_dmi_check(void)
>  		return;
>  
>  	/* On L1400B WLED control the sound card, don't mess with it ... */
> -	if (strncmp(model, "L1400B", 6) == 0) {
> +	if (strncmp(model, "L1400B", 6) == 0)
>  		wlan_status = -1;
> -	}
>  }
>  
>  static bool asus_device_present;