dt-bindings: ata: tegra: Disallow undefined properties

[PATCH] dt-bindings: ata: tegra: Disallow undefined properties

Posted by Rob Herring 2 years, 2 months ago

Device specific bindings should not allow undefined properties. This is
accomplished in json-schema with 'additionalProperties: false'.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
index 3c7a2425f3e6..a17297cbefcb 100644
--- a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
+++ b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
@@ -151,7 +151,7 @@ allOf:
         - interconnects
         - power-domains
 
-additionalProperties: true
+additionalProperties: false
 
 examples:
   - |
-- 
2.42.0

Re: [PATCH] dt-bindings: ata: tegra: Disallow undefined properties

Posted by Damien Le Moal 2 years, 2 months ago

On 10/17/23 00:55, Rob Herring wrote:
> Device specific bindings should not allow undefined properties. This is
> accomplished in json-schema with 'additionalProperties: false'.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Applied to for-6.7. Thanks !

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] dt-bindings: ata: tegra: Disallow undefined properties

Posted by Conor Dooley 2 years, 2 months ago

On Mon, Oct 16, 2023 at 10:55:54AM -0500, Rob Herring wrote:
> Device specific bindings should not allow undefined properties. This is
> accomplished in json-schema with 'additionalProperties: false'.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
> index 3c7a2425f3e6..a17297cbefcb 100644
> --- a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
> @@ -151,7 +151,7 @@ allOf:
>          - interconnects
>          - power-domains
>  
> -additionalProperties: true
> +additionalProperties: false
>  
>  examples:
>    - |
> -- 
> 2.42.0
> 
>