[v1] perf cs-etm: Improve timestamp tracing

[PATCH v1 RESEND 0/2] perf cs-etm: Improve timestamp tracing

Posted by Leo Yan 2 years, 2 months ago

This patch series is to improve timestamp handling in per-thread mode.

The current code doesn't validate timestamp and always return success for
per-thread mode, for a sane implementation, the first patch is to allow
validation timestamp tracing in per-thread mode.

The second patch is to respect timestamp option "--timestamp" or "-T",
when users set this option, the tool will automatically enable hardware
timestamp tracing in Arm CoreSight.

This patch set is rebased on the latest perf-tools-next branch, and
tested on Arm Juno board. And added James Clark's review tags.


Leo Yan (2):
  perf cs-etm: Validate timestamp tracing in per-thread mode
  perf cs-etm: Respect timestamp option

 tools/perf/arch/arm/util/cs-etm.c | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

-- 
2.34.1

Re: [PATCH v1 RESEND 0/2] perf cs-etm: Improve timestamp tracing

Posted by Namhyung Kim 2 years, 2 months ago

On Sat, 14 Oct 2023 15:41:57 +0800, Leo Yan wrote:
> This patch series is to improve timestamp handling in per-thread mode.
> 
> The current code doesn't validate timestamp and always return success for
> per-thread mode, for a sane implementation, the first patch is to allow
> validation timestamp tracing in per-thread mode.
> 
> The second patch is to respect timestamp option "--timestamp" or "-T",
> when users set this option, the tool will automatically enable hardware
> timestamp tracing in Arm CoreSight.
> 
> [...]

Applied to perf-tools-next, thanks!