[PATCH v2] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset

Abel Vesa posted 1 patch 2 years, 2 months ago
drivers/soc/qcom/llcc-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
Posted by Abel Vesa 2 years, 2 months ago
According to documentation, it has increments of 4, not 8.

Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
Reported-by: Unnathi Chalicheemala <quic_uchalich@quicinc.com>
Reviewed-by: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---

Changes since v1:
 * fixed Unnathi's first name typo
 * added Konrad's and Satya's R-b tags

 drivers/soc/qcom/llcc-qcom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 674abd0d6700..fb4085b7cb19 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -47,7 +47,7 @@
 #define LLCC_TRP_STATUSn(n)           (4 + n * SZ_4K)
 #define LLCC_TRP_ATTR0_CFGn(n)        (0x21000 + SZ_8 * n)
 #define LLCC_TRP_ATTR1_CFGn(n)        (0x21004 + SZ_8 * n)
-#define LLCC_TRP_ATTR2_CFGn(n)        (0x21100 + SZ_8 * n)
+#define LLCC_TRP_ATTR2_CFGn(n)        (0x21100 + SZ_4 * n)
 
 #define LLCC_TRP_SCID_DIS_CAP_ALLOC   0x21f00
 #define LLCC_TRP_PCB_ACT              0x21f04
-- 
2.34.1
Re: [PATCH v2] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
Posted by Bjorn Andersson 2 years ago
On Thu, 12 Oct 2023 19:05:09 +0300, Abel Vesa wrote:
> According to documentation, it has increments of 4, not 8.
> 
> 

Applied, thanks!

[1/1] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
      commit: 03970d2fa35497d5a5812d67ce94ca5836335159

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>