media: cec: meson: always include meson sub-directory in Makefile

[PATCH] media: cec: meson: always include meson sub-directory in Makefile

Posted by Marek Szyprowski 2 years, 2 months ago

'meson' directory contains two separate drivers, so it should be added
to Makefile compilation hierarchy unconditionally, because otherwise the
meson-ao-cec-g12a won't be compiled if meson-ao-cec is not selected.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/media/cec/platform/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/cec/platform/Makefile b/drivers/media/cec/platform/Makefile
index 26d2bc778394..a51e98ab4958 100644
--- a/drivers/media/cec/platform/Makefile
+++ b/drivers/media/cec/platform/Makefile
@@ -6,7 +6,7 @@
 # Please keep it in alphabetic order
 obj-$(CONFIG_CEC_CROS_EC) += cros-ec/
 obj-$(CONFIG_CEC_GPIO) += cec-gpio/
-obj-$(CONFIG_CEC_MESON_AO) += meson/
+obj-y += meson/
 obj-$(CONFIG_CEC_SAMSUNG_S5P) += s5p/
 obj-$(CONFIG_CEC_SECO) += seco/
 obj-$(CONFIG_CEC_STI) += sti/
-- 
2.34.1

Re: [PATCH] media: cec: meson: always include meson sub-directory in Makefile

Posted by Hans Verkuil 2 years, 2 months ago

On 10/12/23 12:35, Marek Szyprowski wrote:
> 'meson' directory contains two separate drivers, so it should be added
> to Makefile compilation hierarchy unconditionally, because otherwise the
> meson-ao-cec-g12a won't be compiled if meson-ao-cec is not selected.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Does this need a Fixes tag?

Regards,

	Hans

> ---
>  drivers/media/cec/platform/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/cec/platform/Makefile b/drivers/media/cec/platform/Makefile
> index 26d2bc778394..a51e98ab4958 100644
> --- a/drivers/media/cec/platform/Makefile
> +++ b/drivers/media/cec/platform/Makefile
> @@ -6,7 +6,7 @@
>  # Please keep it in alphabetic order
>  obj-$(CONFIG_CEC_CROS_EC) += cros-ec/
>  obj-$(CONFIG_CEC_GPIO) += cec-gpio/
> -obj-$(CONFIG_CEC_MESON_AO) += meson/
> +obj-y += meson/
>  obj-$(CONFIG_CEC_SAMSUNG_S5P) += s5p/
>  obj-$(CONFIG_CEC_SECO) += seco/
>  obj-$(CONFIG_CEC_STI) += sti/

Re: [PATCH] media: cec: meson: always include meson sub-directory in Makefile

Posted by Marek Szyprowski 2 years, 2 months ago

On 12.10.2023 12:42, Hans Verkuil wrote:
> On 10/12/23 12:35, Marek Szyprowski wrote:
>> 'meson' directory contains two separate drivers, so it should be added
>> to Makefile compilation hierarchy unconditionally, because otherwise the
>> meson-ao-cec-g12a won't be compiled if meson-ao-cec is not selected.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Does this need a Fixes tag?

Fixes: 4be5e8648b0c ("media: move CEC platform drivers to a separate 
directory")

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland