[PATCH v3 0/6] Fixes and improvements for RS485

Lino Sanfilippo posted 6 patches 2 years, 2 months ago
There is a newer version of this series
drivers/tty/serial/imx.c         |  8 ------
drivers/tty/serial/omap-serial.c |  8 +++---
drivers/tty/serial/serial_core.c | 48 ++++++++++++++++++++++----------
drivers/tty/serial/stm32-usart.c |  5 +---
4 files changed, 38 insertions(+), 31 deletions(-)
[PATCH v3 0/6] Fixes and improvements for RS485
Posted by Lino Sanfilippo 2 years, 2 months ago
The following series includes some fixes and improvements around RS485 in
the serial core and UART drivers:

Patch 1: Do not hold the port lock when setting rx-during-tx GPIO
Patch 2: Get rid of useless wrapper pl011_get_rs485_mode()
Patch 3: set missing supported flag for RX during TX GPIO
Patch 4: fix sanitizing check for RTS settings
Patch 5: make sure RS485 is cannot be enabled when it is not supported
Patch 6: imx: do not set RS485 enabled if it is not supported
Patch 7: omap: do not override settings for rs485 support

Changes in v2:
- add missing 'Fixes' tags as requested by Greg
- corrected a typo as pointed out by Hugo
- fix issue in imx driver in the serial core as suggested by Uwe
- partly rephrase some commit messages
- add patch 7

Changes in v3
- Drop patch "Get rid of useless wrapper pl011_get_rs485_mode()" as
  requested by Greg

Lino Sanfilippo (6):
  serial: Do not hold the port lock when setting rx-during-tx GPIO
  serial: core: set missing supported flag for RX during TX GPIO
  serial: core: fix sanitizing check for RTS settings
  serial: core: make sure RS485 cannot be enabled when it is not
    supported
  serial: core, imx: do not set RS485 enabled if it is not supported
  serial: omap: do not override settings for RS485 support

 drivers/tty/serial/imx.c         |  8 ------
 drivers/tty/serial/omap-serial.c |  8 +++---
 drivers/tty/serial/serial_core.c | 48 ++++++++++++++++++++++----------
 drivers/tty/serial/stm32-usart.c |  5 +---
 4 files changed, 38 insertions(+), 31 deletions(-)


base-commit: 94f6f0550c625fab1f373bb86a6669b45e9748b3
-- 
2.40.1

Re: [PATCH v3 0/6] Fixes and improvements for RS485
Posted by Lino Sanfilippo 2 years, 2 months ago

Ccing Uwe.

On 11.10.23 20:15, Lino Sanfilippo wrote:
> The following series includes some fixes and improvements around RS485 in
> the serial core and UART drivers:
> 
> Patch 1: Do not hold the port lock when setting rx-during-tx GPIO
> Patch 2: Get rid of useless wrapper pl011_get_rs485_mode()
> Patch 3: set missing supported flag for RX during TX GPIO
> Patch 4: fix sanitizing check for RTS settings
> Patch 5: make sure RS485 is cannot be enabled when it is not supported
> Patch 6: imx: do not set RS485 enabled if it is not supported
> Patch 7: omap: do not override settings for rs485 support
> 
> Changes in v2:
> - add missing 'Fixes' tags as requested by Greg
> - corrected a typo as pointed out by Hugo
> - fix issue in imx driver in the serial core as suggested by Uwe
> - partly rephrase some commit messages
> - add patch 7
> 
> Changes in v3
> - Drop patch "Get rid of useless wrapper pl011_get_rs485_mode()" as
>   requested by Greg
> 


Sorry Uwe, you gave valuable input for the former version of this series and I
just noticed now that I forgot to Cc you for this version. 

BR,
Lino
Re: [PATCH v3 0/6] Fixes and improvements for RS485
Posted by Uwe Kleine-König 2 years, 2 months ago
Hello Lino,

On Sun, Oct 15, 2023 at 03:03:20PM +0200, Lino Sanfilippo wrote:
> Sorry Uwe, you gave valuable input for the former version of this series and I
> just noticed now that I forgot to Cc you for this version. 

My mail setup works good enough that this series already landed in my
inbox without the explict Cc, but I'm currently doing too much other
stuff to find the time for an appropriate look here, sorry.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
Re: [PATCH v3 0/6] Fixes and improvements for RS485
Posted by Lino Sanfilippo 2 years, 2 months ago
Hi,

On 16.10.23 12:38, Uwe Kleine-König wrote:
> Hello Lino,
>
> On Sun, Oct 15, 2023 at 03:03:20PM +0200, Lino Sanfilippo wrote:
>> Sorry Uwe, you gave valuable input for the former version of this series and I
>> just noticed now that I forgot to Cc you for this version.
>
> My mail setup works good enough that this series already landed in my
> inbox without the explict Cc, but I'm currently doing too much other
> stuff to find the time for an appropriate look here, sorry.
>

No problem, I can fully understand that.

BR,
Lino