[char-misc-next 2/3] mei: docs: add missing entries to kdoc in struct mei_cfg_idx

Tomas Winkler posted 3 patches 2 years, 2 months ago
[char-misc-next 2/3] mei: docs: add missing entries to kdoc in struct mei_cfg_idx
Posted by Tomas Winkler 2 years, 2 months ago
Document all entries in struct mei_cfg_idx.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 drivers/misc/mei/hw-me.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/misc/mei/hw-me.h b/drivers/misc/mei/hw-me.h
index 95cf830b7c7b63e1cf555048..204b92af6c4785beb23f0212 100644
--- a/drivers/misc/mei/hw-me.h
+++ b/drivers/misc/mei/hw-me.h
@@ -102,10 +102,14 @@ static inline bool mei_me_hw_use_polling(const struct mei_me_hw *hw)
  * @MEI_ME_PCH12_SPS_CFG:  Platform Controller Hub Gen12 5.0 and newer
  *                         servers platforms with quirk for
  *                         SPS firmware exclusion.
+ * @MEI_ME_PCH12_SPS_ITOUCH_CFG: Platform Controller Hub Gen12
+ *                         client platforms (iTouch)
  * @MEI_ME_PCH15_CFG:      Platform Controller Hub Gen15 and newer
  * @MEI_ME_PCH15_SPS_CFG:  Platform Controller Hub Gen15 and newer
  *                         servers platforms with quirk for
  *                         SPS firmware exclusion.
+ * @MEI_ME_GSC_CFG:        Graphics System Controller
+ * @MEI_ME_GSCFI_CFG:      Graphics System Controller Firmware Interface
  * @MEI_ME_NUM_CFG:        Upper Sentinel.
  */
 enum mei_cfg_idx {
-- 
2.41.0
Re: [char-misc-next 2/3] mei: docs: add missing entries to kdoc in struct mei_cfg_idx
Posted by Randy Dunlap 2 years, 2 months ago

On 10/11/23 00:43, Tomas Winkler wrote:
> Document all entries in struct mei_cfg_idx.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.


> ---
>  drivers/misc/mei/hw-me.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/misc/mei/hw-me.h b/drivers/misc/mei/hw-me.h
> index 95cf830b7c7b63e1cf555048..204b92af6c4785beb23f0212 100644
> --- a/drivers/misc/mei/hw-me.h
> +++ b/drivers/misc/mei/hw-me.h
> @@ -102,10 +102,14 @@ static inline bool mei_me_hw_use_polling(const struct mei_me_hw *hw)
>   * @MEI_ME_PCH12_SPS_CFG:  Platform Controller Hub Gen12 5.0 and newer
>   *                         servers platforms with quirk for
>   *                         SPS firmware exclusion.
> + * @MEI_ME_PCH12_SPS_ITOUCH_CFG: Platform Controller Hub Gen12
> + *                         client platforms (iTouch)
>   * @MEI_ME_PCH15_CFG:      Platform Controller Hub Gen15 and newer
>   * @MEI_ME_PCH15_SPS_CFG:  Platform Controller Hub Gen15 and newer
>   *                         servers platforms with quirk for
>   *                         SPS firmware exclusion.
> + * @MEI_ME_GSC_CFG:        Graphics System Controller
> + * @MEI_ME_GSCFI_CFG:      Graphics System Controller Firmware Interface
>   * @MEI_ME_NUM_CFG:        Upper Sentinel.
>   */
>  enum mei_cfg_idx {

-- 
~Randy