1. Patchew
  2. linux
  3. [PATCH v3 0/2] Rpmsg support for i.MX DSP with resource table
  4. View patch

[PATCH v3 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

Iuliana Prodan (OSS) posted 2 patches 2 years, 2 months ago
There is a newer version of this series
[PATCH v3 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP
Posted by Iuliana Prodan (OSS) 2 years, 2 months ago 
From: Iuliana Prodan <iuliana.prodan@nxp.com>

Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.

Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index cc406bb338fe..22815b3ea890 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -211,6 +211,22 @@
 			reg = <0 0x92400000 0 0x2000000>;
 			no-map;
 		};
+
+		dsp_vdev0vring0: vdev0vring0@942f0000 {
+			reg = <0 0x942f0000 0 0x8000>;
+			no-map;
+		};
+
+		dsp_vdev0vring1: vdev0vring1@942f8000 {
+			reg = <0 0x942f8000 0 0x8000>;
+			no-map;
+		};
+
+		dsp_vdev0buffer: vdev0buffer@94300000 {
+			compatible = "shared-dma-pool";
+			reg = <0 0x94300000 0 0x100000>;
+			no-map;
+		};
 	};
 
 	pmu {
-- 
2.17.1
Re: [PATCH v3 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP
Posted by Alexander Stein 2 years, 2 months ago 
Hi Iuliana,

Am Dienstag, 10. Oktober 2023, 11:09:29 CEST schrieb Iuliana Prodan (OSS):
> From: Iuliana Prodan <iuliana.prodan@nxp.com>
> 
> Add the reserve-memory nodes used by DSP when the rpmsg
> feature is enabled.
> 
> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
> cc406bb338fe..22815b3ea890 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -211,6 +211,22 @@
>  			reg = <0 0x92400000 0 0x2000000>;
>  			no-map;
>  		};
> +
> +		dsp_vdev0vring0: vdev0vring0@942f0000 {
> +			reg = <0 0x942f0000 0 0x8000>;
> +			no-map;
> +		};
> +
> +		dsp_vdev0vring1: vdev0vring1@942f8000 {
> +			reg = <0 0x942f8000 0 0x8000>;
> +			no-map;
> +		};
> +
> +		dsp_vdev0buffer: vdev0buffer@94300000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0 0x94300000 0 0x100000>;
> +			no-map;
> +		};

Please configure these reserved memories on board level. Not every i.MX8MP 
based board uses this DSP or has these memory addresses available.

Best regards,
Alexander

>  	};
> 
>  	pmu {


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
Re: [PATCH v3 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP
Posted by Iuliana Prodan 2 years, 2 months ago 
Hi Alexander,

On 10/11/2023 8:37 AM, Alexander Stein wrote:
> Hi Iuliana,
>
> Am Dienstag, 10. Oktober 2023, 11:09:29 CEST schrieb Iuliana Prodan (OSS):
>> From: Iuliana Prodan <iuliana.prodan@nxp.com>
>>
>> Add the reserve-memory nodes used by DSP when the rpmsg
>> feature is enabled.
>>
>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
>> cc406bb338fe..22815b3ea890 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> @@ -211,6 +211,22 @@
>>   			reg = <0 0x92400000 0 0x2000000>;
>>   			no-map;
>>   		};
>> +
>> +		dsp_vdev0vring0: vdev0vring0@942f0000 {
>> +			reg = <0 0x942f0000 0 0x8000>;
>> +			no-map;
>> +		};
>> +
>> +		dsp_vdev0vring1: vdev0vring1@942f8000 {
>> +			reg = <0 0x942f8000 0 0x8000>;
>> +			no-map;
>> +		};
>> +
>> +		dsp_vdev0buffer: vdev0buffer@94300000 {
>> +			compatible = "shared-dma-pool";
>> +			reg = <0 0x94300000 0 0x100000>;
>> +			no-map;
>> +		};
> Please configure these reserved memories on board level. Not every i.MX8MP
> based board uses this DSP or has these memory addresses available.

Will it be ok in imx8mp-evk.dts?

Thanks,
Iulia

> Best regards,
> Alexander
>
>>   	};
>>
>>   	pmu {
>
Re: [PATCH v3 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP
Posted by Alexander Stein 2 years, 2 months ago 
Hi Iuliana,

Am Freitag, 13. Oktober 2023, 10:35:17 CEST schrieb Iuliana Prodan:
> Hi Alexander,
> 
> On 10/11/2023 8:37 AM, Alexander Stein wrote:
> > Hi Iuliana,
> > 
> > Am Dienstag, 10. Oktober 2023, 11:09:29 CEST schrieb Iuliana Prodan (OSS):
> >> From: Iuliana Prodan <iuliana.prodan@nxp.com>
> >> 
> >> Add the reserve-memory nodes used by DSP when the rpmsg
> >> feature is enabled.
> >> 
> >> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> >> ---
> >> 
> >>   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
> >>   1 file changed, 16 insertions(+)
> >> 
> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
> >> cc406bb338fe..22815b3ea890 100644
> >> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> @@ -211,6 +211,22 @@
> >> 
> >>   			reg = <0 0x92400000 0 0x2000000>;
> >>   			no-map;
> >>   		
> >>   		};
> >> 
> >> +
> >> +		dsp_vdev0vring0: vdev0vring0@942f0000 {
> >> +			reg = <0 0x942f0000 0 0x8000>;
> >> +			no-map;
> >> +		};
> >> +
> >> +		dsp_vdev0vring1: vdev0vring1@942f8000 {
> >> +			reg = <0 0x942f8000 0 0x8000>;
> >> +			no-map;
> >> +		};
> >> +
> >> +		dsp_vdev0buffer: vdev0buffer@94300000 {
> >> +			compatible = "shared-dma-pool";
> >> +			reg = <0 0x94300000 0 0x100000>;
> >> +			no-map;
> >> +		};
> > 
> > Please configure these reserved memories on board level. Not every i.MX8MP
> > based board uses this DSP or has these memory addresses available.
> 
> Will it be ok in imx8mp-evk.dts?

If that is the board using the DSP and the reserved memory, then yes.

Best regards,
Alexander

> Thanks,
> Iulia
> 
> > Best regards,
> > Alexander
> > 
> >>   	};
> >>   	
> >>   	pmu {


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.