[v3] Several updates for PTT driver

[PATCH v3 0/5] Several updates for PTT driver

Posted by Yicong Yang 2 years, 4 months ago

From: Yicong Yang <yangyicong@hisilicon.com>

This series contains several updates for PTT driver:
- Disable interrupt when trace stops, reverse to what we do in trace start
- Always handle the interrupt in hardirq context
- Optimize the AUX buffer handling to make consumer have more time to process
  the data
- Since we're a uncore PMU so block any task attach operation
- Add a dummy pmu::read() callback since the perf core may use

Change since v2:
- Add fix tag for Patch 5/5
- refine the commit in Patch 3/5, trying to make it more clear
Link: https://lore.kernel.org/all/20230914112223.27165-1-yangyicong@huawei.com/

Change since v1:
- Add Jonathan's tag, thanks
Link: https://lore.kernel.org/all/20230809081825.11518-1-yangyicong@huawei.com/

Junhao He (1):
  hwtracing: hisi_ptt: Add dummy callback pmu::read()

Yicong Yang (4):
  hwtracing: hisi_ptt: Disable interrupt after trace end
  hwtracing: hisi_ptt: Handle the interrupt in hardirq context
  hwtracing: hisi_ptt: Optimize the trace data committing
  hwtracing: hisi_ptt: Don't try to attach a task

 drivers/hwtracing/ptt/hisi_ptt.c | 33 +++++++++++++++++++++-----------
 drivers/hwtracing/ptt/hisi_ptt.h |  1 +
 2 files changed, 23 insertions(+), 11 deletions(-)

-- 
2.24.0

Re: [PATCH v3 0/5] Several updates for PTT driver

Posted by Yicong Yang 2 years, 3 months ago

Hi Suzuki,

a gentle ping..

Hope all previous comments are addressed/clarified. Any further comment on this?

Thanks.

On 2023/10/10 16:47, Yicong Yang wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
> 
> This series contains several updates for PTT driver:
> - Disable interrupt when trace stops, reverse to what we do in trace start
> - Always handle the interrupt in hardirq context
> - Optimize the AUX buffer handling to make consumer have more time to process
>   the data
> - Since we're a uncore PMU so block any task attach operation
> - Add a dummy pmu::read() callback since the perf core may use
> 
> Change since v2:
> - Add fix tag for Patch 5/5
> - refine the commit in Patch 3/5, trying to make it more clear
> Link: https://lore.kernel.org/all/20230914112223.27165-1-yangyicong@huawei.com/
> 
> Change since v1:
> - Add Jonathan's tag, thanks
> Link: https://lore.kernel.org/all/20230809081825.11518-1-yangyicong@huawei.com/
> 
> Junhao He (1):
>   hwtracing: hisi_ptt: Add dummy callback pmu::read()
> 
> Yicong Yang (4):
>   hwtracing: hisi_ptt: Disable interrupt after trace end
>   hwtracing: hisi_ptt: Handle the interrupt in hardirq context
>   hwtracing: hisi_ptt: Optimize the trace data committing
>   hwtracing: hisi_ptt: Don't try to attach a task
> 
>  drivers/hwtracing/ptt/hisi_ptt.c | 33 +++++++++++++++++++++-----------
>  drivers/hwtracing/ptt/hisi_ptt.h |  1 +
>  2 files changed, 23 insertions(+), 11 deletions(-)
>

Re: [PATCH v3 0/5] Several updates for PTT driver

Posted by Suzuki K Poulose 2 years, 3 months ago

On Tue, 10 Oct 2023 16:47:26 +0800, Yicong Yang wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
> 
> This series contains several updates for PTT driver:
> - Disable interrupt when trace stops, reverse to what we do in trace start
> - Always handle the interrupt in hardirq context

I wrapped the commit description to 75 chars for this patch to suppress the
following checkpatch warning and queued it.

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#10:
change of arm-ccn PMU commit 0811ef7e2f54 ("bus: arm-ccn: fix PMU interrupt flags").

total: 0 errors, 1 warnings, 12 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

      "[PATCH] hwtracing: hisi_ptt: Handle the interrupt in hardirq context" has style problems, please review.


> - Optimize the AUX buffer handling to make consumer have more time to process
>   the data
> - Since we're a uncore PMU so block any task attach operation
> - Add a dummy pmu::read() callback since the perf core may use
> 
> [...]

Applied, thanks!

[1/5] hwtracing: hisi_ptt: Disable interrupt after trace end
      https://git.kernel.org/coresight/c/4669551e797a
[2/5] hwtracing: hisi_ptt: Handle the interrupt in hardirq context
      https://git.kernel.org/coresight/c/e8b7d8718c51
[3/5] hwtracing: hisi_ptt: Optimize the trace data committing
      https://git.kernel.org/coresight/c/7a527d4d9273
[4/5] hwtracing: hisi_ptt: Don't try to attach a task
      https://git.kernel.org/coresight/c/7d52e2cfef91
[5/5] hwtracing: hisi_ptt: Add dummy callback pmu::read()
      https://git.kernel.org/coresight/c/4708eada8bd6

Best regards,
-- 
Suzuki K Poulose <suzuki.poulose@arm.com>

Re: [PATCH v3 0/5] Several updates for PTT driver

Posted by Yicong Yang 2 years, 3 months ago

On 2023/10/18 1:01, Suzuki K Poulose wrote:
> On Tue, 10 Oct 2023 16:47:26 +0800, Yicong Yang wrote:
>> From: Yicong Yang <yangyicong@hisilicon.com>
>>
>> This series contains several updates for PTT driver:
>> - Disable interrupt when trace stops, reverse to what we do in trace start
>> - Always handle the interrupt in hardirq context
> 
> I wrapped the commit description to 75 chars for this patch to suppress the
> following checkpatch warning and queued it.

Thanks! Will take care next time.

> 
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #10:
> change of arm-ccn PMU commit 0811ef7e2f54 ("bus: arm-ccn: fix PMU interrupt flags").
> 
> total: 0 errors, 1 warnings, 12 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
>       "[PATCH] hwtracing: hisi_ptt: Handle the interrupt in hardirq context" has style problems, please review.
> 
> 
>> - Optimize the AUX buffer handling to make consumer have more time to process
>>   the data
>> - Since we're a uncore PMU so block any task attach operation
>> - Add a dummy pmu::read() callback since the perf core may use
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/5] hwtracing: hisi_ptt: Disable interrupt after trace end
>       https://git.kernel.org/coresight/c/4669551e797a
> [2/5] hwtracing: hisi_ptt: Handle the interrupt in hardirq context
>       https://git.kernel.org/coresight/c/e8b7d8718c51
> [3/5] hwtracing: hisi_ptt: Optimize the trace data committing
>       https://git.kernel.org/coresight/c/7a527d4d9273
> [4/5] hwtracing: hisi_ptt: Don't try to attach a task
>       https://git.kernel.org/coresight/c/7d52e2cfef91
> [5/5] hwtracing: hisi_ptt: Add dummy callback pmu::read()
>       https://git.kernel.org/coresight/c/4708eada8bd6
> 
> Best regards,
>