MAINTAINERS: coresight: Add filename catchall for Coresight

[PATCH] MAINTAINERS: coresight: Add filename catchall for Coresight

Posted by James Clark 2 years, 2 months ago

There are a few files missing from the list like test_arm_coresight.sh
and arm-coresight.txt. These could be picked up just with a name match.

Signed-off-by: James Clark <james.clark@arm.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 90f13281d297..3ee45066b7e4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2066,6 +2066,7 @@ F:	tools/perf/arch/arm/util/pmu.c
 F:	tools/perf/tests/shell/coresight/*
 F:	tools/perf/util/cs-etm-decoder/*
 F:	tools/perf/util/cs-etm.*
+N:	coresight
 
 ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE
 M:	Hans Ulli Kroll <ulli.kroll@googlemail.com>
-- 
2.34.1

Re: [PATCH] MAINTAINERS: coresight: Add filename catchall for Coresight

Posted by Mike Leach 2 years, 2 months ago

Won't this also pick up....

drivers/accel/habanalabs/gaudi/gaudi_coresight.c

?

Which isn't part of anything we maintain

On Thu, 5 Oct 2023 at 09:40, James Clark <james.clark@arm.com> wrote:
>
> There are a few files missing from the list like test_arm_coresight.sh
> and arm-coresight.txt. These could be picked up just with a name match.
>
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 90f13281d297..3ee45066b7e4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2066,6 +2066,7 @@ F:        tools/perf/arch/arm/util/pmu.c
>  F:     tools/perf/tests/shell/coresight/*
>  F:     tools/perf/util/cs-etm-decoder/*
>  F:     tools/perf/util/cs-etm.*
> +N:     coresight
>
>  ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE
>  M:     Hans Ulli Kroll <ulli.kroll@googlemail.com>
> --
> 2.34.1
>


-- 
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK

Re: [PATCH] MAINTAINERS: coresight: Add filename catchall for Coresight

Posted by James Clark 2 years, 2 months ago

On 05/10/2023 13:08, Mike Leach wrote:
> Won't this also pick up....
> 
> drivers/accel/habanalabs/gaudi/gaudi_coresight.c
> 
> ?
> 
> Which isn't part of anything we maintain
> 

Ah ok I did try to check for other non Arm Coresight files with
Coresight in the name and didn't find any, but I must have missed that one.

I will just explicitly add the missing ones instead.

Although on further inspection it does seem to be related to some Arm
Coresight implementation, although not one that fits in the existing
Perf or Coresight driver framework. So I'm not sure if there could ever
be any sharing of code between the two, maybe not from an initial glance.

> On Thu, 5 Oct 2023 at 09:40, James Clark <james.clark@arm.com> wrote:
>>
>> There are a few files missing from the list like test_arm_coresight.sh
>> and arm-coresight.txt. These could be picked up just with a name match.
>>
>> Signed-off-by: James Clark <james.clark@arm.com>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 90f13281d297..3ee45066b7e4 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2066,6 +2066,7 @@ F:        tools/perf/arch/arm/util/pmu.c
>>  F:     tools/perf/tests/shell/coresight/*
>>  F:     tools/perf/util/cs-etm-decoder/*
>>  F:     tools/perf/util/cs-etm.*
>> +N:     coresight
>>
>>  ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE
>>  M:     Hans Ulli Kroll <ulli.kroll@googlemail.com>
>> --
>> 2.34.1
>>
> 
>

Re: [PATCH] MAINTAINERS: coresight: Add filename catchall for Coresight

Posted by Suzuki K Poulose 2 years, 2 months ago

On 05/10/2023 13:42, James Clark wrote:
> 
> 
> On 05/10/2023 13:08, Mike Leach wrote:
>> Won't this also pick up....
>>
>> drivers/accel/habanalabs/gaudi/gaudi_coresight.c
>>
>> ?
>>
>> Which isn't part of anything we maintain
>>
> 
> Ah ok I did try to check for other non Arm Coresight files with
> Coresight in the name and didn't find any, but I must have missed that one.
> 
> I will just explicitly add the missing ones instead.
> 
> Although on further inspection it does seem to be related to some Arm
> Coresight implementation, although not one that fits in the existing

True, indeed it is hand written code sequence that we do for the
normal CoreSight components. The access to the components looks a bit
convoluted. However, with the coresight_access abstraction we have,
it is possible to abstract it away and move the driver framework to
CoreSight drivers.

> Perf or Coresight driver framework. So I'm not sure if there could ever
> be any sharing of code between the two, maybe not from an initial glance.

Nothing that we could do at the moment without support from the
habana labs folks.

Suzuki

> 
>> On Thu, 5 Oct 2023 at 09:40, James Clark <james.clark@arm.com> wrote:
>>>
>>> There are a few files missing from the list like test_arm_coresight.sh
>>> and arm-coresight.txt. These could be picked up just with a name match.
>>>
>>> Signed-off-by: James Clark <james.clark@arm.com>
>>> ---
>>>   MAINTAINERS | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 90f13281d297..3ee45066b7e4 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -2066,6 +2066,7 @@ F:        tools/perf/arch/arm/util/pmu.c
>>>   F:     tools/perf/tests/shell/coresight/*
>>>   F:     tools/perf/util/cs-etm-decoder/*
>>>   F:     tools/perf/util/cs-etm.*
>>> +N:     coresight
>>>
>>>   ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE
>>>   M:     Hans Ulli Kroll <ulli.kroll@googlemail.com>
>>> --
>>> 2.34.1
>>>
>>
>>