[PATCH] bpf: Fix the comment for bpf_restore_data_end()

Akihiko Odaki posted 1 patch 2 years, 2 months ago
include/linux/filter.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] bpf: Fix the comment for bpf_restore_data_end()
Posted by Akihiko Odaki 2 years, 2 months ago
The comment used to say:
> Restore data saved by bpf_compute_data_pointers().

But bpf_compute_data_pointers() does not save the data;
bpf_compute_and_save_data_end() does.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 include/linux/filter.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/filter.h b/include/linux/filter.h
index 761af6b3cf2b..bf7ad887943c 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -694,7 +694,7 @@ static inline void bpf_compute_and_save_data_end(
 	cb->data_end  = skb->data + skb_headlen(skb);
 }
 
-/* Restore data saved by bpf_compute_data_pointers(). */
+/* Restore data saved by bpf_compute_and_save_data_end(). */
 static inline void bpf_restore_data_end(
 	struct sk_buff *skb, void *saved_data_end)
 {
-- 
2.42.0
Re: [PATCH] bpf: Fix the comment for bpf_restore_data_end()
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 2 months ago
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Thu,  5 Oct 2023 16:21:36 +0900 you wrote:
> The comment used to say:
> > Restore data saved by bpf_compute_data_pointers().
> 
> But bpf_compute_data_pointers() does not save the data;
> bpf_compute_and_save_data_end() does.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> 
> [...]

Here is the summary with links:
  - bpf: Fix the comment for bpf_restore_data_end()
    https://git.kernel.org/bpf/bpf-next/c/9c8c3fa3a52b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH] bpf: Fix the comment for bpf_restore_data_end()
Posted by Stanislav Fomichev 2 years, 2 months ago
On 10/05, Akihiko Odaki wrote:
> The comment used to say:
> > Restore data saved by bpf_compute_data_pointers().
> 
> But bpf_compute_data_pointers() does not save the data;
> bpf_compute_and_save_data_end() does.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

Please use [PATCH bpf-next] (or bpf, depending on the tree) for bpf
patches in the future.

Acked-by: Stanislav Fomichev <sdf@google.com>