drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE

[PATCH] drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE

Posted by Rob Clark 2 years, 3 months ago

From: Rob Clark <robdclark@chromium.org>

Dependency for CONFIG_DRM_PANEL_EDP.  Missing this was causing the drm
driver to not probe on devices that use panel-edp.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 drivers/gpu/drm/ci/arm.config   | 1 +
 drivers/gpu/drm/ci/arm64.config | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/ci/arm.config b/drivers/gpu/drm/ci/arm.config
index 871f4de063ad..411e814819a8 100644
--- a/drivers/gpu/drm/ci/arm.config
+++ b/drivers/gpu/drm/ci/arm.config
@@ -24,6 +24,7 @@ CONFIG_DRM_LIMA=y
 CONFIG_DRM_PANEL_SIMPLE=y
 CONFIG_PWM_CROS_EC=y
 CONFIG_BACKLIGHT_PWM=y
+CONFIG_BACKLIGHT_CLASS_DEVICE=y
 
 CONFIG_ROCKCHIP_CDN_DP=n
 
diff --git a/drivers/gpu/drm/ci/arm64.config b/drivers/gpu/drm/ci/arm64.config
index 817e18ddfd4f..45f9deb7c4f6 100644
--- a/drivers/gpu/drm/ci/arm64.config
+++ b/drivers/gpu/drm/ci/arm64.config
@@ -26,6 +26,7 @@ CONFIG_DRM_ETNAVIV=y
 CONFIG_DRM_I2C_ADV7511=y
 CONFIG_PWM_CROS_EC=y
 CONFIG_BACKLIGHT_PWM=y
+CONFIG_BACKLIGHT_CLASS_DEVICE=y
 
 CONFIG_ROCKCHIP_CDN_DP=n
 
-- 
2.41.0

Re: [PATCH] drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE

Posted by Maxime Ripard 2 years, 2 months ago

On Mon, 02 Oct 2023 09:47:14 -0700, Rob Clark wrote:
> Dependency for CONFIG_DRM_PANEL_EDP.  Missing this was causing the drm
> driver to not probe on devices that use panel-edp.
> 
> 

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime

Re: [PATCH] drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE

Posted by Helen Koike 2 years, 3 months ago


On 02/10/2023 13:47, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> Dependency for CONFIG_DRM_PANEL_EDP.  Missing this was causing the drm
> driver to not probe on devices that use panel-edp.
> 
> Signed-off-by: Rob Clark <robdclark@chromium.org>

Thank you a lot!

Now sc7180, apq8096 and sdm845 are probing!

Tested-by: Helen Koike <helen.koike@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>

> ---
>   drivers/gpu/drm/ci/arm.config   | 1 +
>   drivers/gpu/drm/ci/arm64.config | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ci/arm.config b/drivers/gpu/drm/ci/arm.config
> index 871f4de063ad..411e814819a8 100644
> --- a/drivers/gpu/drm/ci/arm.config
> +++ b/drivers/gpu/drm/ci/arm.config
> @@ -24,6 +24,7 @@ CONFIG_DRM_LIMA=y
>   CONFIG_DRM_PANEL_SIMPLE=y
>   CONFIG_PWM_CROS_EC=y
>   CONFIG_BACKLIGHT_PWM=y
> +CONFIG_BACKLIGHT_CLASS_DEVICE=y
>   
>   CONFIG_ROCKCHIP_CDN_DP=n
>   
> diff --git a/drivers/gpu/drm/ci/arm64.config b/drivers/gpu/drm/ci/arm64.config
> index 817e18ddfd4f..45f9deb7c4f6 100644
> --- a/drivers/gpu/drm/ci/arm64.config
> +++ b/drivers/gpu/drm/ci/arm64.config
> @@ -26,6 +26,7 @@ CONFIG_DRM_ETNAVIV=y
>   CONFIG_DRM_I2C_ADV7511=y
>   CONFIG_PWM_CROS_EC=y
>   CONFIG_BACKLIGHT_PWM=y
> +CONFIG_BACKLIGHT_CLASS_DEVICE=y
>   
>   CONFIG_ROCKCHIP_CDN_DP=n
>