chelsio: Annotate structs with __counted_by

[PATCH 0/5] chelsio: Annotate structs with __counted_by

Posted by Kees Cook 2 years, 2 months ago

Hi,

This annotates several chelsio structures with the coming __counted_by
attribute for bounds checking of flexible arrays at run-time. For more details,
see commit dd06e72e68bc ("Compiler Attributes: Add __counted_by macro").

Thanks!

-Kees

Kees Cook (5):
  chelsio/l2t: Annotate struct l2t_data with __counted_by
  cxgb4: Annotate struct clip_tbl with __counted_by
  cxgb4: Annotate struct cxgb4_tc_u32_table with __counted_by
  cxgb4: Annotate struct sched_table with __counted_by
  cxgb4: Annotate struct smt_data with __counted_by

 drivers/net/ethernet/chelsio/cxgb3/l2t.h                | 2 +-
 drivers/net/ethernet/chelsio/cxgb4/clip_tbl.h           | 2 +-
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h | 2 +-
 drivers/net/ethernet/chelsio/cxgb4/l2t.c                | 2 +-
 drivers/net/ethernet/chelsio/cxgb4/sched.h              | 2 +-
 drivers/net/ethernet/chelsio/cxgb4/smt.h                | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.34.1

Re: [PATCH 0/5] chelsio: Annotate structs with __counted_by

Posted by Kees Cook 2 years, 2 months ago

On Fri, Sep 29, 2023 at 11:11:44AM -0700, Kees Cook wrote:
> Hi,
> 
> This annotates several chelsio structures with the coming __counted_by
> attribute for bounds checking of flexible arrays at run-time. For more details,
> see commit dd06e72e68bc ("Compiler Attributes: Add __counted_by macro").
> 
> Thanks!
> 
> -Kees
> 
> Kees Cook (5):
>   chelsio/l2t: Annotate struct l2t_data with __counted_by
>   cxgb4: Annotate struct clip_tbl with __counted_by
>   cxgb4: Annotate struct cxgb4_tc_u32_table with __counted_by
>   cxgb4: Annotate struct sched_table with __counted_by
>   cxgb4: Annotate struct smt_data with __counted_by
> 
>  drivers/net/ethernet/chelsio/cxgb3/l2t.h                | 2 +-
>  drivers/net/ethernet/chelsio/cxgb4/clip_tbl.h           | 2 +-
>  drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h | 2 +-
>  drivers/net/ethernet/chelsio/cxgb4/l2t.c                | 2 +-
>  drivers/net/ethernet/chelsio/cxgb4/sched.h              | 2 +-
>  drivers/net/ethernet/chelsio/cxgb4/smt.h                | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)

Hm, it looks like this is not "Supported" any more? I'm getting bounces
from "Raju Rangoju <rajur@chelsio.com>" ...

CXGB4 ETHERNET DRIVER (CXGB4)
M:      Raju Rangoju <rajur@chelsio.com>
L:      netdev@vger.kernel.org
S:      Supported
W:      http://www.chelsio.com
F:      drivers/net/ethernet/chelsio/cxgb4/

-Kees

-- 
Kees Cook

Re: [PATCH 0/5] chelsio: Annotate structs with __counted_by

Posted by Jakub Kicinski 2 years, 2 months ago

On Fri, 29 Sep 2023 12:44:45 -0700 Kees Cook wrote:
> On Fri, Sep 29, 2023 at 11:11:44AM -0700, Kees Cook wrote:
> > Hi,
> > 
> > This annotates several chelsio structures with the coming __counted_by
> > attribute for bounds checking of flexible arrays at run-time. For more details,
> > see commit dd06e72e68bc ("Compiler Attributes: Add __counted_by macro").
> > 
> > Thanks!
> > 
> > -Kees
> > 
> > Kees Cook (5):
> >   chelsio/l2t: Annotate struct l2t_data with __counted_by
> >   cxgb4: Annotate struct clip_tbl with __counted_by
> >   cxgb4: Annotate struct cxgb4_tc_u32_table with __counted_by
> >   cxgb4: Annotate struct sched_table with __counted_by
> >   cxgb4: Annotate struct smt_data with __counted_by
> > 
> >  drivers/net/ethernet/chelsio/cxgb3/l2t.h                | 2 +-
> >  drivers/net/ethernet/chelsio/cxgb4/clip_tbl.h           | 2 +-
> >  drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h | 2 +-
> >  drivers/net/ethernet/chelsio/cxgb4/l2t.c                | 2 +-
> >  drivers/net/ethernet/chelsio/cxgb4/sched.h              | 2 +-
> >  drivers/net/ethernet/chelsio/cxgb4/smt.h                | 2 +-
> >  6 files changed, 6 insertions(+), 6 deletions(-)  
> 
> Hm, it looks like this is not "Supported" any more? I'm getting bounces
> from "Raju Rangoju <rajur@chelsio.com>" ...
> 
> CXGB4 ETHERNET DRIVER (CXGB4)
> M:      Raju Rangoju <rajur@chelsio.com>
> L:      netdev@vger.kernel.org
> S:      Supported
> W:      http://www.chelsio.com
> F:      drivers/net/ethernet/chelsio/cxgb4/

Hi Ayush,

any idea who should be maintaining the Ethernet part of cxgb4 
at this point?

Re: [PATCH 0/5] chelsio: Annotate structs with __counted_by

Posted by Ayush Sawal 2 years, 2 months ago

On 10/3/2023 12:01 AM, Jakub Kicinski wrote:
> On Fri, 29 Sep 2023 12:44:45 -0700 Kees Cook wrote:
>> On Fri, Sep 29, 2023 at 11:11:44AM -0700, Kees Cook wrote:
>>> Hi,
>>>
>>> This annotates several chelsio structures with the coming __counted_by
>>> attribute for bounds checking of flexible arrays at run-time. For more details,
>>> see commit dd06e72e68bc ("Compiler Attributes: Add __counted_by macro").
>>>
>>> Thanks!
>>>
>>> -Kees
>>>
>>> Kees Cook (5):
>>>    chelsio/l2t: Annotate struct l2t_data with __counted_by
>>>    cxgb4: Annotate struct clip_tbl with __counted_by
>>>    cxgb4: Annotate struct cxgb4_tc_u32_table with __counted_by
>>>    cxgb4: Annotate struct sched_table with __counted_by
>>>    cxgb4: Annotate struct smt_data with __counted_by
>>>
>>>   drivers/net/ethernet/chelsio/cxgb3/l2t.h                | 2 +-
>>>   drivers/net/ethernet/chelsio/cxgb4/clip_tbl.h           | 2 +-
>>>   drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h | 2 +-
>>>   drivers/net/ethernet/chelsio/cxgb4/l2t.c                | 2 +-
>>>   drivers/net/ethernet/chelsio/cxgb4/sched.h              | 2 +-
>>>   drivers/net/ethernet/chelsio/cxgb4/smt.h                | 2 +-
>>>   6 files changed, 6 insertions(+), 6 deletions(-)
>> Hm, it looks like this is not "Supported" any more? I'm getting bounces
>> from "Raju Rangoju <rajur@chelsio.com>" ...
>>
>> CXGB4 ETHERNET DRIVER (CXGB4)
>> M:      Raju Rangoju <rajur@chelsio.com>
>> L:      netdev@vger.kernel.org
>> S:      Supported
>> W:      http://www.chelsio.com
>> F:      drivers/net/ethernet/chelsio/cxgb4/
> Hi Ayush,
>
> any idea who should be maintaining the Ethernet part of cxgb4
> at this point?

Hi Jakub,

  The current maintainer for cxgb4 driver is Sourabh Sagar 
<sourabh.sagar@chelsio.com>, I have added him in the CC.
  He will update the MAINTAINERS file for cxgb4 driver.

  Thanks,
  Ayush

Re: [PATCH 0/5] chelsio: Annotate structs with __counted_by

Posted by Jakub Kicinski 2 years, 2 months ago

On Fri, 6 Oct 2023 01:58:54 +0530 Ayush Sawal wrote:
>   The current maintainer for cxgb4 driver is Sourabh Sagar 
> <sourabh.sagar@chelsio.com>, I have added him in the CC.
>   He will update the MAINTAINERS file for cxgb4 driver.

Thanks & looking forward to the update!

Re: [PATCH 0/5] chelsio: Annotate structs with __counted_by

Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 2 months ago

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 29 Sep 2023 11:11:44 -0700 you wrote:
> Hi,
> 
> This annotates several chelsio structures with the coming __counted_by
> attribute for bounds checking of flexible arrays at run-time. For more details,
> see commit dd06e72e68bc ("Compiler Attributes: Add __counted_by macro").
> 
> Thanks!
> 
> [...]

Here is the summary with links:
  - [1/5] chelsio/l2t: Annotate struct l2t_data with __counted_by
    https://git.kernel.org/netdev/net-next/c/3bbae5f1c651
  - [2/5] cxgb4: Annotate struct clip_tbl with __counted_by
    https://git.kernel.org/netdev/net-next/c/c3db467b0822
  - [3/5] cxgb4: Annotate struct cxgb4_tc_u32_table with __counted_by
    https://git.kernel.org/netdev/net-next/c/157c56a4fede
  - [4/5] cxgb4: Annotate struct sched_table with __counted_by
    https://git.kernel.org/netdev/net-next/c/ceba9725fb45
  - [5/5] cxgb4: Annotate struct smt_data with __counted_by
    https://git.kernel.org/netdev/net-next/c/1508cb7e0752

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html