gpio: fx6408: Convert to use maple tree register cache

[PATCH] gpio: fx6408: Convert to use maple tree register cache

Posted by Mark Brown 2 years, 4 months ago

The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/gpio/gpio-fxl6408.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-fxl6408.c b/drivers/gpio/gpio-fxl6408.c
index c14b5cc5e519..991549888904 100644
--- a/drivers/gpio/gpio-fxl6408.c
+++ b/drivers/gpio/gpio-fxl6408.c
@@ -84,7 +84,7 @@ static const struct regmap_config regmap = {
 	.rd_table = &rd_table,
 	.volatile_table = &volatile_table,
 
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.num_reg_defaults_raw = FXL6408_REG_INT_STS + 1,
 };
 

---
base-commit: 6465e260f48790807eef06b583b38ca9789b6072
change-id: 20230929-gpio-fx16408-476b144746bc

Best regards,
-- 
Mark Brown <broonie@kernel.org>

Re: [PATCH] gpio: fx6408: Convert to use maple tree register cache

Posted by Bartosz Golaszewski 2 years, 4 months ago

On Fri, Sep 29, 2023 at 4:11 PM Mark Brown <broonie@kernel.org> wrote:
>
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  drivers/gpio/gpio-fxl6408.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-fxl6408.c b/drivers/gpio/gpio-fxl6408.c
> index c14b5cc5e519..991549888904 100644
> --- a/drivers/gpio/gpio-fxl6408.c
> +++ b/drivers/gpio/gpio-fxl6408.c
> @@ -84,7 +84,7 @@ static const struct regmap_config regmap = {
>         .rd_table = &rd_table,
>         .volatile_table = &volatile_table,
>
> -       .cache_type = REGCACHE_RBTREE,
> +       .cache_type = REGCACHE_MAPLE,
>         .num_reg_defaults_raw = FXL6408_REG_INT_STS + 1,
>  };
>
>
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20230929-gpio-fx16408-476b144746bc
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>

Applied, thanks!

Bart

Re: [PATCH] gpio: fx6408: Convert to use maple tree register cache

Posted by Andy Shevchenko 2 years, 4 months ago

On Fri, Sep 29, 2023 at 04:11:24PM +0200, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko