Update prefixes for AON power domain

[-next v1 1/2] dt-bindings: power: Update prefixes for AON power domain

Posted by Changhuang Liang 2 years, 4 months ago

Use "JH7110_AON_PD_" prefix for AON power doamin for JH7110 SoC.

Reviewed-by: Walker Chen <walker.chen@starfivetech.com>
Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
---
 include/dt-bindings/power/starfive,jh7110-pmu.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h
index 341e2a0676ba..7b4f24927dee 100644
--- a/include/dt-bindings/power/starfive,jh7110-pmu.h
+++ b/include/dt-bindings/power/starfive,jh7110-pmu.h
@@ -14,7 +14,8 @@
 #define JH7110_PD_ISP		5
 #define JH7110_PD_VENC		6
 
-#define JH7110_PD_DPHY_TX	0
-#define JH7110_PD_DPHY_RX	1
+/* AON Power Domain */
+#define JH7110_AON_PD_DPHY_TX	0
+#define JH7110_AON_PD_DPHY_RX	1
 
 #endif
-- 
2.25.1

Re: [-next v1 1/2] dt-bindings: power: Update prefixes for AON power domain

Posted by Ulf Hansson 2 years, 4 months ago

On Wed, 27 Sept 2023 at 15:07, Changhuang Liang
<changhuang.liang@starfivetech.com> wrote:
>
> Use "JH7110_AON_PD_" prefix for AON power doamin for JH7110 SoC.
>
> Reviewed-by: Walker Chen <walker.chen@starfivetech.com>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>

Applied for next (spelling mistake fixed), thanks!

Kind regards
Uffe


> ---
>  include/dt-bindings/power/starfive,jh7110-pmu.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h
> index 341e2a0676ba..7b4f24927dee 100644
> --- a/include/dt-bindings/power/starfive,jh7110-pmu.h
> +++ b/include/dt-bindings/power/starfive,jh7110-pmu.h
> @@ -14,7 +14,8 @@
>  #define JH7110_PD_ISP          5
>  #define JH7110_PD_VENC         6
>
> -#define JH7110_PD_DPHY_TX      0
> -#define JH7110_PD_DPHY_RX      1
> +/* AON Power Domain */
> +#define JH7110_AON_PD_DPHY_TX  0
> +#define JH7110_AON_PD_DPHY_RX  1
>
>  #endif
> --
> 2.25.1
>

Re: [-next v1 1/2] dt-bindings: power: Update prefixes for AON power domain

Posted by Geert Uytterhoeven 2 years, 4 months ago

Hi Changhuang,

Thanks for your patch!

On Wed, Sep 27, 2023 at 3:07 PM Changhuang Liang
<changhuang.liang@starfivetech.com> wrote:
> Use "JH7110_AON_PD_" prefix for AON power doamin for JH7110 SoC.

domain

>
> Reviewed-by: Walker Chen <walker.chen@starfivetech.com>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [-next v1 1/2] dt-bindings: power: Update prefixes for AON power domain

Posted by Conor Dooley 2 years, 4 months ago

On Wed, Sep 27, 2023 at 06:07:33AM -0700, Changhuang Liang wrote:
> Use "JH7110_AON_PD_" prefix for AON power doamin for JH7110 SoC.
> 
> Reviewed-by: Walker Chen <walker.chen@starfivetech.com>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  include/dt-bindings/power/starfive,jh7110-pmu.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h
> index 341e2a0676ba..7b4f24927dee 100644
> --- a/include/dt-bindings/power/starfive,jh7110-pmu.h
> +++ b/include/dt-bindings/power/starfive,jh7110-pmu.h
> @@ -14,7 +14,8 @@
>  #define JH7110_PD_ISP		5
>  #define JH7110_PD_VENC		6
>  
> -#define JH7110_PD_DPHY_TX	0
> -#define JH7110_PD_DPHY_RX	1
> +/* AON Power Domain */
> +#define JH7110_AON_PD_DPHY_TX	0
> +#define JH7110_AON_PD_DPHY_RX	1
>  
>  #endif
> -- 
> 2.25.1
>

Re: [-next v1 1/2] dt-bindings: power: Update prefixes for AON power domain

Posted by Conor Dooley 2 years, 4 months ago

On Wed, Sep 27, 2023 at 03:52:44PM +0100, Conor Dooley wrote:
> On Wed, Sep 27, 2023 at 06:07:33AM -0700, Changhuang Liang wrote:
> > Use "JH7110_AON_PD_" prefix for AON power doamin for JH7110 SoC.
> > 
> > Reviewed-by: Walker Chen <walker.chen@starfivetech.com>
> > Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Also, It'd have been worth mentioning that there are no ABI issues here
due to this stuff not yet being in Linus' tree.

> 
> Thanks,
> Conor.
> 
> > ---
> >  include/dt-bindings/power/starfive,jh7110-pmu.h | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h
> > index 341e2a0676ba..7b4f24927dee 100644
> > --- a/include/dt-bindings/power/starfive,jh7110-pmu.h
> > +++ b/include/dt-bindings/power/starfive,jh7110-pmu.h
> > @@ -14,7 +14,8 @@
> >  #define JH7110_PD_ISP		5
> >  #define JH7110_PD_VENC		6
> >  
> > -#define JH7110_PD_DPHY_TX	0
> > -#define JH7110_PD_DPHY_RX	1
> > +/* AON Power Domain */
> > +#define JH7110_AON_PD_DPHY_TX	0
> > +#define JH7110_AON_PD_DPHY_RX	1
> >  
> >  #endif
> > -- 
> > 2.25.1
> >