[PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas

Rob Herring posted 1 patch 2 years, 4 months ago
Documentation/devicetree/bindings/nvmem/u-boot,env.yaml | 2 ++
1 file changed, 2 insertions(+)
[PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
Posted by Rob Herring 2 years, 4 months ago
Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/nvmem/u-boot,env.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
index 36d97fb87865..9c36afc7084b 100644
--- a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
+++ b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
@@ -51,6 +51,8 @@ properties:
   ethaddr:
     type: object
     description: Ethernet interfaces base MAC address.
+    additionalProperties: false
+
     properties:
       "#nvmem-cell-cells":
         description: The first argument is a MAC address offset.
-- 
2.40.1
Re: [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
Posted by Srinivas Kandagatla 2 years, 4 months ago
On Tue, 26 Sep 2023 11:45:25 -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
> 
> 

Applied, thanks!

[1/1] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
      commit: 8beb2ec54b65eb08891c9b9c23428712d46d8e15

Best regards,
-- 
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Re: [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
Posted by Rafał Miłecki 2 years, 4 months ago
On 2023-09-26 18:45, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Thanks!

Acked-by: Rafał Miłecki <rafal@milecki.pl>
Re: [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
Posted by Conor Dooley 2 years, 4 months ago
On Tue, Sep 26, 2023 at 11:45:25AM -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>



Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.