Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 + 1 file changed, 1 insertion(+)
Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
index 895415772d1d..24422fd56e83 100644
--- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
@@ -91,6 +91,7 @@ allOf:
additionalProperties:
type: object
+ additionalProperties: false
description:
Subnodes of the SCP represent rpmsg devices. The names of the devices
are not important. The properties of these nodes are defined by the
--
2.40.1
Hi Rob, On Tue, Sep 26, 2023 at 11:45:08AM -0500, Rob Herring wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > index 895415772d1d..24422fd56e83 100644 > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > @@ -91,6 +91,7 @@ allOf: > > additionalProperties: > type: object > + additionalProperties: false Things have changed in the remoteproc tree [1] and this patch doesn't apply. Please see if it is still needed. Thanks, Mathieu [1]. https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git/tree/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml?h=rproc-next#n80 > description: > Subnodes of the SCP represent rpmsg devices. The names of the devices > are not important. The properties of these nodes are defined by the > -- > 2.40.1 >
On Thu, Sep 28, 2023 at 2:31 PM Mathieu Poirier <mathieu.poirier@linaro.org> wrote: > > Hi Rob, > > On Tue, Sep 26, 2023 at 11:45:08AM -0500, Rob Herring wrote: > > Just as unevaluatedProperties or additionalProperties are required at > > the top level of schemas, they should (and will) also be required for > > child node schemas. That ensures only documented properties are > > present for any node. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > index 895415772d1d..24422fd56e83 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > @@ -91,6 +91,7 @@ allOf: > > > > additionalProperties: > > type: object > > + additionalProperties: false > > Things have changed in the remoteproc tree [1] and this patch doesn't apply. > Please see if it is still needed. It is not needed any more. Thanks, Rob
On Tue, Sep 26, 2023 at 11:45:08AM -0500, Rob Herring wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- Acked-by: Conor Dooley <conor.dooley@microchip.com> > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > index 895415772d1d..24422fd56e83 100644 > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > @@ -91,6 +91,7 @@ allOf: > > additionalProperties: > type: object > + additionalProperties: false > description: > Subnodes of the SCP represent rpmsg devices. The names of the devices > are not important. The properties of these nodes are defined by the > -- > 2.40.1 >
Il 26/09/23 18:45, Rob Herring ha scritto: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. > > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
© 2016 - 2024 Red Hat, Inc.