1. Patchew
  2. linux
  3. View series

[PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats

Raghavendra Kakarla posted 1 patch 2 years, 4 months ago
There is a newer version of this series
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
1 file changed, 5 insertions(+)
[PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
Posted by Raghavendra Kakarla 2 years, 4 months ago 
Add device node for sleep stats driver which provides various
low power mode stats.

Cc: devicetree@vger.kernel.org
Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 9f4f58e831a4..cee7491de675 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -1912,6 +1912,11 @@
 			#clock-cells = <0>;
 		};
 
+		sram@c3f0000 {
+			compatible = "qcom,rpmh-stats";
+			reg = <0 0x0c3f0000 0 0x400>;
+		};
+
 		spmi_bus: spmi@c440000 {
 			compatible = "qcom,spmi-pmic-arb";
 			reg = <0x0 0x0c440000 0x0 0x1100>,
-- 
2.17.1
Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
Posted by Krzysztof Kozlowski 2 years, 4 months ago 
On 26/09/2023 06:48, Raghavendra Kakarla wrote:
> Add device node for sleep stats driver which provides various
> low power mode stats.
> 
> Cc: devicetree@vger.kernel.org

No need to keep such Cc in commit log.

> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9f4f58e831a4..cee7491de675 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -1912,6 +1912,11 @@
>  			#clock-cells = <0>;
>  		};
>  
> +		sram@c3f0000 {
> +			compatible = "qcom,rpmh-stats";
> +			reg = <0 0x0c3f0000 0 0x400>;

Please use consistent format - hex.


Best regards,
Krzysztof
Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
Posted by Raghavendra Kakarla 2 years, 4 months ago 
On 9/27/2023 1:29 PM, Krzysztof Kozlowski wrote:
> On 26/09/2023 06:48, Raghavendra Kakarla wrote:
>> Add device node for sleep stats driver which provides various
>> low power mode stats.
>>
>> Cc: devicetree@vger.kernel.org
> No need to keep such Cc in commit log.
Sure, will remove this.
>
>> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> index 9f4f58e831a4..cee7491de675 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> @@ -1912,6 +1912,11 @@
>>   			#clock-cells = <0>;
>>   		};
>>   
>> +		sram@c3f0000 {
>> +			compatible = "qcom,rpmh-stats";
>> +			reg = <0 0x0c3f0000 0 0x400>;
> Please use consistent format - hex.
yes, will address this in next patch.
>
>
> Best regards,
> Krzysztof
>
Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
Posted by Konrad Dybcio 2 years, 4 months ago 
On 26.09.2023 06:48, Raghavendra Kakarla wrote:
> Add device node for sleep stats driver which provides various
> low power mode stats.
> 
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9f4f58e831a4..cee7491de675 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -1912,6 +1912,11 @@
>  			#clock-cells = <0>;
>  		};
>  
> +		sram@c3f0000 {
> +			compatible = "qcom,rpmh-stats";
> +			reg = <0 0x0c3f0000 0 0x400>;
Other nodes (such as the one 5 lines below) use 0x0 instead of
0 to fill out bits 63:32. Please make it consistent.

Konrad
> +		};
> +
>  		spmi_bus: spmi@c440000 {
>  			compatible = "qcom,spmi-pmic-arb";
>  			reg = <0x0 0x0c440000 0x0 0x1100>,
Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
Posted by Raghavendra Kakarla 2 years, 4 months ago 
On 9/27/2023 12:36 AM, Konrad Dybcio wrote:
> On 26.09.2023 06:48, Raghavendra Kakarla wrote:
>> Add device node for sleep stats driver which provides various
>> low power mode stats.
>>
>> Cc: devicetree@vger.kernel.org
>> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> index 9f4f58e831a4..cee7491de675 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> @@ -1912,6 +1912,11 @@
>>   			#clock-cells = <0>;
>>   		};
>>   
>> +		sram@c3f0000 {
>> +			compatible = "qcom,rpmh-stats";
>> +			reg = <0 0x0c3f0000 0 0x400>;
> Other nodes (such as the one 5 lines below) use 0x0 instead of
> 0 to fill out bits 63:32. Please make it consistent.
Sure, will address this in next patch.
>
> Konrad
>> +		};
>> +
>>   		spmi_bus: spmi@c440000 {
>>   			compatible = "qcom,spmi-pmic-arb";
>>   			reg = <0x0 0x0c440000 0x0 0x1100>,
Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats
Posted by Andrew Halaney 2 years, 4 months ago 
On Tue, Sep 26, 2023 at 10:18:14AM +0530, Raghavendra Kakarla wrote:
> Add device node for sleep stats driver which provides various
> low power mode stats.
> 
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com>

Tested-by: Andrew Halaney <ahalaney@redhat.com>

I took this for a quick spin when testing -next today, and I see the
qcom_stats directory, can view the file output, etc. Probably good enough
to consider this simple change tested. I also don't see any new issues
when running:
ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CHECK_DTBS=1 qcom/sa8775p-ride.dtb

> ---

Generally you should put a description of what changed since v1
in this section.

>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9f4f58e831a4..cee7491de675 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -1912,6 +1912,11 @@
>  			#clock-cells = <0>;
>  		};
>  
> +		sram@c3f0000 {
> +			compatible = "qcom,rpmh-stats";
> +			reg = <0 0x0c3f0000 0 0x400>;
> +		};
> +
>  		spmi_bus: spmi@c440000 {
>  			compatible = "qcom,spmi-pmic-arb";
>  			reg = <0x0 0x0c440000 0x0 0x1100>,
> -- 
> 2.17.1
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.