[PATCH] firmware: raspberrypi: Fix devm_rpi_firmware_get documentation

Kieran Bingham posted 1 patch 2 years, 4 months ago
drivers/firmware/raspberrypi.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] firmware: raspberrypi: Fix devm_rpi_firmware_get documentation
Posted by Kieran Bingham 2 years, 4 months ago
From: Kieran Bingham <kieran.bingham@ideasonboard.com>

The function documentation for devm_rpi_firmware_get() was missing
a description for the dev parameter.

Provide it and clear the warning produced here.

Fixes: f663204c9a1f ("firmware: raspberrypi: Introduce devm_rpi_firmware_get()")
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 drivers/firmware/raspberrypi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
index f66efaa5196d..4cd290a60fba 100644
--- a/drivers/firmware/raspberrypi.c
+++ b/drivers/firmware/raspberrypi.c
@@ -378,6 +378,7 @@ EXPORT_SYMBOL_GPL(rpi_firmware_get);
 
 /**
  * devm_rpi_firmware_get - Get pointer to rpi_firmware structure.
+ * @dev:              The firmware device structure
  * @firmware_node:    Pointer to the firmware Device Tree node.
  *
  * Returns NULL is the firmware device is not ready.
-- 
2.34.1
Re: [PATCH] firmware: raspberrypi: Fix devm_rpi_firmware_get documentation
Posted by Florian Fainelli 2 years, 4 months ago
From: Florian Fainelli <f.fainelli@gmail.com>

On Mon, 25 Sep 2023 16:18:11 +0100, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote:
> From: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> The function documentation for devm_rpi_firmware_get() was missing
> a description for the dev parameter.
> 
> Provide it and clear the warning produced here.
> 
> Fixes: f663204c9a1f ("firmware: raspberrypi: Introduce devm_rpi_firmware_get()")
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian