[v3] Add APSS clock driver support for IPQ5018

[PATCH V3 0/3] Add APSS clock driver support for IPQ5018

Posted by Gokul Sriram Palanisamy 2 years, 2 months ago

This series adds support for the APSS clock to bump the CPU frequency
above 800MHz. APSS PLL found in the IPQ5018 is of type Stromer. 

- The first patch in the series adds the required a53pll compatible.

- The second patch reuses Stormer Plus PLL offsets, adds configuration values
  for Stromer.

- The third patch adds dts nodes to enable the pll along with the cpu
  operating frequency table.

This series depends on below series
https://patchwork.kernel.org/project/linux-arm-msm/cover/20230913-gpll_cleanup-v2-0-c8ceb1a37680@quicinc.com/

Changes in v3:
- Addressed review comment by Dmitry in patch 3.

Changes in v2:
- Addressed review comments
- Adds dependency on above mentioned patch series for dropping
  CLK_SET_RATE_PARENT flag from GPLL clocks, GPLL0 clock provider for
  mailbox
- Add CPU operating point at 800MHz based on the review comments.

Gokul Sriram Palanisamy (3):
  dt-bindings: clock: qcom,a53pll: add IPQ5018 compatible
  clk: qcom: apss-ipq-pll: add support for IPQ5018
  arm64: dts: qcom: ipq5018: enable the CPUFreq support

 .../bindings/clock/qcom,a53pll.yaml           |  1 +
 arch/arm64/boot/dts/qcom/ipq5018.dtsi         | 40 +++++++++++++++++++
 drivers/clk/qcom/apss-ipq-pll.c               | 21 ++++++++++
 3 files changed, 62 insertions(+)

-- 
2.34.1

Re: [PATCH V3 0/3] Add APSS clock driver support for IPQ5018

Posted by Gokul Sriram P 2 years, 1 month ago

Hi everyone, a gentle remainder to review and acknowledge the change.

Regards,
Gokul

On 9/25/2023 3:58 PM, Gokul Sriram Palanisamy wrote:
> This series adds support for the APSS clock to bump the CPU frequency
> above 800MHz. APSS PLL found in the IPQ5018 is of type Stromer.
>
> - The first patch in the series adds the required a53pll compatible.
>
> - The second patch reuses Stormer Plus PLL offsets, adds configuration values
>    for Stromer.
>
> - The third patch adds dts nodes to enable the pll along with the cpu
>    operating frequency table.
>
> This series depends on below series
> https://patchwork.kernel.org/project/linux-arm-msm/cover/20230913-gpll_cleanup-v2-0-c8ceb1a37680@quicinc.com/
>
> Changes in v3:
> - Addressed review comment by Dmitry in patch 3.
>
> Changes in v2:
> - Addressed review comments
> - Adds dependency on above mentioned patch series for dropping
>    CLK_SET_RATE_PARENT flag from GPLL clocks, GPLL0 clock provider for
>    mailbox
> - Add CPU operating point at 800MHz based on the review comments.
>
> Gokul Sriram Palanisamy (3):
>    dt-bindings: clock: qcom,a53pll: add IPQ5018 compatible
>    clk: qcom: apss-ipq-pll: add support for IPQ5018
>    arm64: dts: qcom: ipq5018: enable the CPUFreq support
>
>   .../bindings/clock/qcom,a53pll.yaml           |  1 +
>   arch/arm64/boot/dts/qcom/ipq5018.dtsi         | 40 +++++++++++++++++++
>   drivers/clk/qcom/apss-ipq-pll.c               | 21 ++++++++++
>   3 files changed, 62 insertions(+)
>

Re: [PATCH V3 0/3] Add APSS clock driver support for IPQ5018

Posted by Krzysztof Kozlowski 2 years, 1 month ago

On 27/10/2023 10:02, Gokul Sriram P wrote:
> Hi everyone, a gentle remainder to review and acknowledge the change.

Really everyone? So what do you miss from me? Any why do you think that
I did not perform my duties?

Best regards,
Krzysztof

Re: (subset) [PATCH V3 0/3] Add APSS clock driver support for IPQ5018

Posted by Bjorn Andersson 2 years ago

On Mon, 25 Sep 2023 15:58:23 +0530, Gokul Sriram Palanisamy wrote:
> This series adds support for the APSS clock to bump the CPU frequency
> above 800MHz. APSS PLL found in the IPQ5018 is of type Stromer.
> 
> - The first patch in the series adds the required a53pll compatible.
> 
> - The second patch reuses Stormer Plus PLL offsets, adds configuration values
>   for Stromer.
> 
> [...]

Applied, thanks!

[3/3] arm64: dts: qcom: ipq5018: enable the CPUFreq support
      commit: 3e4b53e04281ed3d9c7a4329c027097265c04d54

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>