[PATCH v3] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert txt to yaml

Nik Bune posted 1 patch 2 years, 4 months ago
.../watchdog/atmel,at91rm9200-wdt.yaml        | 33 +++++++++++++++++++
.../watchdog/atmel-at91rm9200-wdt.txt         |  9 -----
2 files changed, 33 insertions(+), 9 deletions(-)
create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
[PATCH v3] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert txt to yaml
Posted by Nik Bune 2 years, 4 months ago
Convert txt file to yaml.

Signed-off-by: Nik Bune <n2h9z4@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

Changes in v3:
- Removed trailing whitespace in an element of the maintainers list.

v2 patch: https://lore.kernel.org/linux-devicetree/20230924172004.59208-1-n2h9z4@gmail.com/ 

 .../watchdog/atmel,at91rm9200-wdt.yaml        | 33 +++++++++++++++++++
 .../watchdog/atmel-at91rm9200-wdt.txt         |  9 -----
 2 files changed, 33 insertions(+), 9 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
 delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt

diff --git a/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
new file mode 100644
index 000000000000..7af3571d89f2
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/atmel,at91rm9200-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel AT91RM9200 System Timer Watchdog
+
+maintainers:
+  - Nicolas Ferre <nicolas.ferre@microchip.com>
+
+allOf:
+  - $ref: watchdog.yaml#
+
+properties:
+  compatible:
+    const: atmel,at91rm9200-wdt
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    watchdog@fffffd00 {
+        compatible = "atmel,at91rm9200-wdt";
+        reg = <0xfffffd00 0x10>;
+    };
diff --git a/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt b/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
deleted file mode 100644
index d4d86cf8f9eb..000000000000
--- a/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
+++ /dev/null
@@ -1,9 +0,0 @@
-Atmel AT91RM9200 System Timer Watchdog
-
-Required properties:
-- compatible: must be "atmel,at91sam9260-wdt".
-
-Example:
-	watchdog@fffffd00 {
-		compatible = "atmel,at91rm9200-wdt";
-	};
-- 
2.34.1
Re: [PATCH v3] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert txt to yaml
Posted by Rob Herring 2 years, 3 months ago
On Sun, 24 Sep 2023 20:19:59 +0200, Nik Bune wrote:
> Convert txt file to yaml.
> 
> Signed-off-by: Nik Bune <n2h9z4@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> 
> Changes in v3:
> - Removed trailing whitespace in an element of the maintainers list.
> 
> v2 patch: https://lore.kernel.org/linux-devicetree/20230924172004.59208-1-n2h9z4@gmail.com/
> 
>  .../watchdog/atmel,at91rm9200-wdt.yaml        | 33 +++++++++++++++++++
>  .../watchdog/atmel-at91rm9200-wdt.txt         |  9 -----
>  2 files changed, 33 insertions(+), 9 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
> 

It seems watchdog bindings aren't getting applied, so I've applied it. 
Wim, please take watchdog bindings in the future unless noted otherwise.

Rob
Re: [PATCH v3] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert txt to yaml
Posted by Wim Van Sebroeck 2 years, 3 months ago
Hi Rob,

> 
> On Sun, 24 Sep 2023 20:19:59 +0200, Nik Bune wrote:
> > Convert txt file to yaml.
> > 
> > Signed-off-by: Nik Bune <n2h9z4@gmail.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > 
> > Changes in v3:
> > - Removed trailing whitespace in an element of the maintainers list.
> > 
> > v2 patch: https://lore.kernel.org/linux-devicetree/20230924172004.59208-1-n2h9z4@gmail.com/
> > 
> >  .../watchdog/atmel,at91rm9200-wdt.yaml        | 33 +++++++++++++++++++
> >  .../watchdog/atmel-at91rm9200-wdt.txt         |  9 -----
> >  2 files changed, 33 insertions(+), 9 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
> > 
> 
> It seems watchdog bindings aren't getting applied, so I've applied it. 
> Wim, please take watchdog bindings in the future unless noted otherwise.

I was going to add them now, but since you allready applied them, I will leave them out this time.

Kind regards,
Wim.
Re: [PATCH v3] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert txt to yaml
Posted by Krzysztof Kozlowski 2 years, 3 months ago
On 29/10/2023 17:22, Wim Van Sebroeck wrote:
> Hi Rob,
> 
>>
>> On Sun, 24 Sep 2023 20:19:59 +0200, Nik Bune wrote:
>>> Convert txt file to yaml.
>>>
>>> Signed-off-by: Nik Bune <n2h9z4@gmail.com>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>>
>>> Changes in v3:
>>> - Removed trailing whitespace in an element of the maintainers list.
>>>
>>> v2 patch: https://lore.kernel.org/linux-devicetree/20230924172004.59208-1-n2h9z4@gmail.com/
>>>
>>>  .../watchdog/atmel,at91rm9200-wdt.yaml        | 33 +++++++++++++++++++
>>>  .../watchdog/atmel-at91rm9200-wdt.txt         |  9 -----
>>>  2 files changed, 33 insertions(+), 9 deletions(-)
>>>  create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
>>>  delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
>>>
>>
>> It seems watchdog bindings aren't getting applied, so I've applied it. 
>> Wim, please take watchdog bindings in the future unless noted otherwise.
> 
> I was going to add them now, but since you allready applied them, I will leave them out this time.

Now is merge window and patches are supposed to be in next much before
the window (if possible).

Best regards,
Krzysztof
Re: [PATCH v3] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert txt to yaml
Posted by Rob Herring 2 years, 4 months ago
On Sun, Sep 24, 2023 at 08:19:59PM +0200, Nik Bune wrote:
> Convert txt file to yaml.
> 
> Signed-off-by: Nik Bune <n2h9z4@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> 
> Changes in v3:
> - Removed trailing whitespace in an element of the maintainers list.
> 
> v2 patch: https://lore.kernel.org/linux-devicetree/20230924172004.59208-1-n2h9z4@gmail.com/ 
> 
>  .../watchdog/atmel,at91rm9200-wdt.yaml        | 33 +++++++++++++++++++
>  .../watchdog/atmel-at91rm9200-wdt.txt         |  9 -----
>  2 files changed, 33 insertions(+), 9 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt

Are the watchdog maintainers going to pick up this and other watchdog 
bindings?

Rob
Re: [PATCH v3] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert txt to yaml
Posted by Guenter Roeck 2 years, 4 months ago
On Tue, Oct 10, 2023 at 08:29:21AM -0500, Rob Herring wrote:
> On Sun, Sep 24, 2023 at 08:19:59PM +0200, Nik Bune wrote:
> > Convert txt file to yaml.
> > 
> > Signed-off-by: Nik Bune <n2h9z4@gmail.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > 
> > Changes in v3:
> > - Removed trailing whitespace in an element of the maintainers list.
> > 
> > v2 patch: https://lore.kernel.org/linux-devicetree/20230924172004.59208-1-n2h9z4@gmail.com/ 
> > 
> >  .../watchdog/atmel,at91rm9200-wdt.yaml        | 33 +++++++++++++++++++
> >  .../watchdog/atmel-at91rm9200-wdt.txt         |  9 -----
> >  2 files changed, 33 insertions(+), 9 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
> 
> Are the watchdog maintainers going to pick up this and other watchdog 
> bindings?
> 

Tricky question. I am way behind with my reviews, and historically you have
picked up some of themm, so I really never know what to do with bindings.

Guenter
Re: [PATCH v3] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert txt to yaml
Posted by Rob Herring 2 years, 4 months ago
On Tue, Oct 10, 2023 at 8:56 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Tue, Oct 10, 2023 at 08:29:21AM -0500, Rob Herring wrote:
> > On Sun, Sep 24, 2023 at 08:19:59PM +0200, Nik Bune wrote:
> > > Convert txt file to yaml.
> > >
> > > Signed-off-by: Nik Bune <n2h9z4@gmail.com>
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > ---
> > >
> > > Changes in v3:
> > > - Removed trailing whitespace in an element of the maintainers list.
> > >
> > > v2 patch: https://lore.kernel.org/linux-devicetree/20230924172004.59208-1-n2h9z4@gmail.com/
> > >
> > >  .../watchdog/atmel,at91rm9200-wdt.yaml        | 33 +++++++++++++++++++
> > >  .../watchdog/atmel-at91rm9200-wdt.txt         |  9 -----
> > >  2 files changed, 33 insertions(+), 9 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
> >
> > Are the watchdog maintainers going to pick up this and other watchdog
> > bindings?
> >
>
> Tricky question. I am way behind with my reviews, and historically you have
> picked up some of themm, so I really never know what to do with bindings.

The default is the subsystem maintainers take them, but yes I do pick
up stuff from time to time for $reasons. Largely that was early on in
schema conversions and there wasn't much checking, but now that's much
better and I only tend to pick up stuff if it's been weeks without
getting applied. Last cycle I found a few wdog bindings that hadn't
been applied (from Apr or May), so I've been keeping more of an eye on
them.

Rob