drivers/net/dsa/microchip/ksz8795_reg.h | 7 -- drivers/net/dsa/microchip/ksz9477.c | 77 ++++++++++++ drivers/net/dsa/microchip/ksz9477.h | 2 + drivers/net/dsa/microchip/ksz9477_reg.h | 7 -- drivers/net/dsa/microchip/ksz_common.c | 149 ++++++++++++++++++++++++ drivers/net/dsa/microchip/ksz_common.h | 10 ++ drivers/net/dsa/xrs700x/xrs700x.c | 18 ++- include/net/dsa.h | 13 ++- net/dsa/port.c | 5 +- net/dsa/port.h | 3 +- net/dsa/slave.c | 9 +- net/dsa/tag_ksz.c | 8 ++ 12 files changed, 283 insertions(+), 25 deletions(-)
This patch series provides support for HSR HW offloading in KSZ9477 switch IC. To test this feature: ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision 45 version 1 ip link set dev lan1 up ip link set dev lan2 up ip a add 192.168.0.1/24 dev hsr0 ip link set dev hsr0 up To remove HSR network device: ip link del hsr0 To test if one can adjust MAC address: ip link set lan2 address 00:01:02:AA:BB:CC It is also possible to create another HSR interface, but it will only support HSR is software - e.g. ip link add name hsr1 type hsr slave1 lan3 slave2 lan4 supervision 45 version 1 Test HW: Two KSZ9477-EVB boards with HSR ports set to "Port1" and "Port2". Performance SW used: nuttcp -S --nofork nuttcp -vv -T 60 -r 192.168.0.2 nuttcp -vv -T 60 -t 192.168.0.2 Code: v6.6.0-rc2+ Linux net-next repository SHA1: 5a1b322cb0b7d0d33a2d13462294dc0f46911172 Tested HSR v0 and v1 Results: With KSZ9477 offloading support added: RX: 100 Mbps TX: 98 Mbps With no offloading RX: 63 Mbps TX: 63 Mbps Lukasz Majewski (2): net: dsa: tag_ksz: Extend ksz9477_xmit() for HSR frame duplication net: dsa: microchip: Enable HSR offloading for KSZ9477 Vladimir Oltean (3): net: dsa: propagate extack to ds->ops->port_hsr_join() net: dsa: notify drivers of MAC address changes on user ports net: dsa: microchip: move REG_SW_MAC_ADDR to dev->info->regs[] drivers/net/dsa/microchip/ksz8795_reg.h | 7 -- drivers/net/dsa/microchip/ksz9477.c | 77 ++++++++++++ drivers/net/dsa/microchip/ksz9477.h | 2 + drivers/net/dsa/microchip/ksz9477_reg.h | 7 -- drivers/net/dsa/microchip/ksz_common.c | 149 ++++++++++++++++++++++++ drivers/net/dsa/microchip/ksz_common.h | 10 ++ drivers/net/dsa/xrs700x/xrs700x.c | 18 ++- include/net/dsa.h | 13 ++- net/dsa/port.c | 5 +- net/dsa/port.h | 3 +- net/dsa/slave.c | 9 +- net/dsa/tag_ksz.c | 8 ++ 12 files changed, 283 insertions(+), 25 deletions(-) -- 2.20.1
On Fri, Sep 22, 2023 at 03:31:03PM +0200, Lukasz Majewski wrote: > This patch series provides support for HSR HW offloading in KSZ9477 > switch IC. > > To test this feature: > ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision 45 version 1 > ip link set dev lan1 up > ip link set dev lan2 up > ip a add 192.168.0.1/24 dev hsr0 > ip link set dev hsr0 up > > To remove HSR network device: > ip link del hsr0 > > To test if one can adjust MAC address: > ip link set lan2 address 00:01:02:AA:BB:CC > > It is also possible to create another HSR interface, but it will > only support HSR is software - e.g. > ip link add name hsr1 type hsr slave1 lan3 slave2 lan4 supervision 45 version 1 > > Test HW: > Two KSZ9477-EVB boards with HSR ports set to "Port1" and "Port2". > > Performance SW used: > nuttcp -S --nofork > nuttcp -vv -T 60 -r 192.168.0.2 > nuttcp -vv -T 60 -t 192.168.0.2 > > Code: v6.6.0-rc2+ Linux net-next repository > SHA1: 5a1b322cb0b7d0d33a2d13462294dc0f46911172 > > Tested HSR v0 and v1 > Results: > With KSZ9477 offloading support added: RX: 100 Mbps TX: 98 Mbps > With no offloading RX: 63 Mbps TX: 63 Mbps Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> Thanks!
Hi Vladimir, > On Fri, Sep 22, 2023 at 03:31:03PM +0200, Lukasz Majewski wrote: > > This patch series provides support for HSR HW offloading in KSZ9477 > > switch IC. > > > > To test this feature: > > ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision > > 45 version 1 ip link set dev lan1 up > > ip link set dev lan2 up > > ip a add 192.168.0.1/24 dev hsr0 > > ip link set dev hsr0 up > > > > To remove HSR network device: > > ip link del hsr0 > > > > To test if one can adjust MAC address: > > ip link set lan2 address 00:01:02:AA:BB:CC > > > > It is also possible to create another HSR interface, but it will > > only support HSR is software - e.g. > > ip link add name hsr1 type hsr slave1 lan3 slave2 lan4 supervision > > 45 version 1 > > > > Test HW: > > Two KSZ9477-EVB boards with HSR ports set to "Port1" and "Port2". > > > > Performance SW used: > > nuttcp -S --nofork > > nuttcp -vv -T 60 -r 192.168.0.2 > > nuttcp -vv -T 60 -t 192.168.0.2 > > > > Code: v6.6.0-rc2+ Linux net-next repository > > SHA1: 5a1b322cb0b7d0d33a2d13462294dc0f46911172 > > > > Tested HSR v0 and v1 > > Results: > > With KSZ9477 offloading support added: RX: 100 Mbps TX: 98 Mbps > > With no offloading RX: 63 Mbps TX: 63 Mbps > > Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > Thanks! I hope, that it will find its way to net-next soon :-). Thanks for your help and patience. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Hi Vladimir, Andrew, Woojung, > Hi Vladimir, > > > On Fri, Sep 22, 2023 at 03:31:03PM +0200, Lukasz Majewski wrote: > > > This patch series provides support for HSR HW offloading in > > > KSZ9477 switch IC. > > > > > > To test this feature: > > > ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision > > > 45 version 1 ip link set dev lan1 up > > > ip link set dev lan2 up > > > ip a add 192.168.0.1/24 dev hsr0 > > > ip link set dev hsr0 up > > > > > > To remove HSR network device: > > > ip link del hsr0 > > > > > > To test if one can adjust MAC address: > > > ip link set lan2 address 00:01:02:AA:BB:CC > > > > > > It is also possible to create another HSR interface, but it will > > > only support HSR is software - e.g. > > > ip link add name hsr1 type hsr slave1 lan3 slave2 lan4 supervision > > > 45 version 1 > > > > > > Test HW: > > > Two KSZ9477-EVB boards with HSR ports set to "Port1" and "Port2". > > > > > > Performance SW used: > > > nuttcp -S --nofork > > > nuttcp -vv -T 60 -r 192.168.0.2 > > > nuttcp -vv -T 60 -t 192.168.0.2 > > > > > > Code: v6.6.0-rc2+ Linux net-next repository > > > SHA1: 5a1b322cb0b7d0d33a2d13462294dc0f46911172 > > > > > > Tested HSR v0 and v1 > > > Results: > > > With KSZ9477 offloading support added: RX: 100 Mbps TX: 98 Mbps > > > With no offloading RX: 63 Mbps TX: 63 > > > Mbps > > > > Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > > > Thanks! > > I hope, that it will find its way to net-next soon :-). > I'm a bit puzzled with this patch series - will it be pulled directly to net-next [1] or is there any other (KSZ maintainer's?) tree to which it will be first pulled and then PR will be send to net-next? Thanks in advance for the clarification. > Thanks for your help and patience. > Links: [1] - https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/log/ > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Erika Unter > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: > lukma@denx.de Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Tue, Oct 03, 2023 at 09:58:32AM +0200, Lukasz Majewski wrote: > I'm a bit puzzled with this patch series - will it be pulled directly > to net-next [1] or is there any other (KSZ maintainer's?) tree to which > it will be first pulled and then PR will be send to net-next? > > Thanks in advance for the clarification. > > Links: > > [1] - > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/log/ No, there's no other tree than net-next. I see your patch was marked as "Changes requested", let me see if I can transition it back to "Under review" so that it gains the netdev maintainers' attention again: https://patchwork.kernel.org/project/netdevbpf/cover/20230922133108.2090612-1-lukma@denx.de/ pw-bot: under-review
Hi Vladimir, > On Tue, Oct 03, 2023 at 09:58:32AM +0200, Lukasz Majewski wrote: > > I'm a bit puzzled with this patch series - will it be pulled > > directly to net-next [1] or is there any other (KSZ maintainer's?) > > tree to which it will be first pulled and then PR will be send to > > net-next? > > > > Thanks in advance for the clarification. > > > > Links: > > > > [1] - > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/log/ > > > > No, there's no other tree than net-next. I see your patch was marked > as "Changes requested", let me see if I can transition it back to > "Under review" so that it gains the netdev maintainers' attention > again: > > https://patchwork.kernel.org/project/netdevbpf/cover/20230922133108.2090612-1-lukma@denx.de/ > > pw-bot: under-review Thanks! I've just noticed that there is a WARNING: https://patchwork.kernel.org/project/netdevbpf/patch/20230922133108.2090612-6-lukma@denx.de/ but then on the newest kernel checkpatch.pl is silent: ./scripts/checkpatch.pl 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch total: 0 errors, 0 warnings, 0 checks, 277 lines checked 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch has no obvious style problems and is ready for submission. Does the checkpatch for patchwork differs in any way from mainline? Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Tue, 3 Oct 2023 14:51:06 +0200 Lukasz Majewski wrote: > I've just noticed that there is a WARNING: > https://patchwork.kernel.org/project/netdevbpf/patch/20230922133108.2090612-6-lukma@denx.de/ > > but then on the newest kernel checkpatch.pl is silent: > ./scripts/checkpatch.pl > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch total: 0 > errors, 0 warnings, 0 checks, 277 lines checked > > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch has no > obvious style problems and is ready for submission. > > Does the checkpatch for patchwork differs in any way from mainline? We run: checkpatch with --strict --max-line-length=80 https://github.com/kuba-moo/nipa/blob/master/tests/patch/checkpatch/checkpatch.sh The "multiple new lines" warning on patch 2 looks legit, no?
On Tue, 3 Oct 2023 06:42:13 -0700 Jakub Kicinski <kuba@kernel.org> wrote: > On Tue, 3 Oct 2023 14:51:06 +0200 Lukasz Majewski wrote: > > I've just noticed that there is a WARNING: > > https://patchwork.kernel.org/project/netdevbpf/patch/20230922133108.2090612-6-lukma@denx.de/ > > > > but then on the newest kernel checkpatch.pl is silent: > > ./scripts/checkpatch.pl > > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch > > total: 0 errors, 0 warnings, 0 checks, 277 lines checked > > > > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch has > > no obvious style problems and is ready for submission. > > > > Does the checkpatch for patchwork differs in any way from mainline? > > > > We run: > > checkpatch with --strict --max-line-length=80 > > https://github.com/kuba-moo/nipa/blob/master/tests/patch/checkpatch/checkpatch.sh > > The "multiple new lines" warning on patch 2 looks legit, no? Indeed - the: '--strict --max-line-length=80' makes the difference... If I may ask - why it is added? Or to ask in other way - why the "vanila" checkpatch is not enough for net-dev ? Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Hello:
This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 22 Sep 2023 15:31:03 +0200 you wrote:
> This patch series provides support for HSR HW offloading in KSZ9477
> switch IC.
>
> To test this feature:
> ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision 45 version 1
> ip link set dev lan1 up
> ip link set dev lan2 up
> ip a add 192.168.0.1/24 dev hsr0
> ip link set dev hsr0 up
>
> [...]
Here is the summary with links:
- [v6,net-next,1/5] net: dsa: propagate extack to ds->ops->port_hsr_join()
https://git.kernel.org/netdev/net-next/c/fefe5dc4afea
- [v6,net-next,2/5] net: dsa: notify drivers of MAC address changes on user ports
https://git.kernel.org/netdev/net-next/c/6715042cd112
- [v6,net-next,3/5] net: dsa: tag_ksz: Extend ksz9477_xmit() for HSR frame duplication
https://git.kernel.org/netdev/net-next/c/5e5db71a92c5
- [v6,net-next,4/5] net: dsa: microchip: move REG_SW_MAC_ADDR to dev->info->regs[]
https://git.kernel.org/netdev/net-next/c/e5de2ad163e7
- [v6,net-next,5/5] net: dsa: microchip: Enable HSR offloading for KSZ9477
https://git.kernel.org/netdev/net-next/c/2d61298fdd7b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
© 2016 - 2025 Red Hat, Inc.