ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor

[PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor

Posted by Matti Lehtimäki 2 years, 4 months ago

Fix hall sensor GPIO polarity and also allow disabling the sensor.
Remove unneeded interrupt.

Fixes: f15623bda1dc ("ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 (SM-T530)")
Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
---
 arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
index 884d99297d4c..f516e0426bb9 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -45,11 +45,11 @@ gpio-hall-sensor {
 
 		event-hall-sensor {
 			label = "Hall Effect Sensor";
-			gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>;
-			interrupts = <&tlmm 110 IRQ_TYPE_EDGE_FALLING>;
+			gpios = <&tlmm 110 GPIO_ACTIVE_LOW>;
 			linux,input-type = <EV_SW>;
 			linux,code = <SW_LID>;
 			debounce-interval = <15>;
+			linux,can-disable;
 			wakeup-source;
 		};
 	};
-- 
2.39.2

Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor

Posted by Bjorn Andersson 2 years, 4 months ago

On Fri, 22 Sep 2023 04:12:11 +0300, Matti Lehtimäki wrote:
> Fix hall sensor GPIO polarity and also allow disabling the sensor.
> Remove unneeded interrupt.
> 
> 

Applied, thanks!

[1/1] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor
      commit: 0b73519790d29e4bc71afc4882a9aa9ea649bcf7

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor

Posted by Luca Weiss 2 years, 4 months ago

On Freitag, 22. September 2023 03:12:11 CEST Matti Lehtimäki wrote:
> Fix hall sensor GPIO polarity and also allow disabling the sensor.
> Remove unneeded interrupt.
> 
> Fixes: f15623bda1dc ("ARM: dts: qcom: Add support for Samsung Galaxy Tab 4
> 10.1 (SM-T530)")
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>

Reviewed-by: Luca Weiss <luca@z3ntu.xyz>

> ---
>  arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts index
> 884d99297d4c..f516e0426bb9 100644
> --- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> @@ -45,11 +45,11 @@ gpio-hall-sensor {
> 
>  		event-hall-sensor {
>  			label = "Hall Effect Sensor";
> -			gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>;
> -			interrupts = <&tlmm 110 IRQ_TYPE_EDGE_FALLING>;
> +			gpios = <&tlmm 110 GPIO_ACTIVE_LOW>;
>  			linux,input-type = <EV_SW>;
>  			linux,code = <SW_LID>;
>  			debounce-interval = <15>;
> +			linux,can-disable;
>  			wakeup-source;
>  		};
>  	};