If the i.MX8QXP clock provider is built-in but the MXC_CLK is
built as module, build fails:

aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
clk-imx8-acm.c:(.text+0x3d0): undefined reference to `imx_check_clk_hws'

Fix that by selecting MXC_CLK in case of CLK_IMX8QXP.

Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
Closes: https://lore.kernel.org/all/8b77219e-b59e-40f1-96f1-980a0b2debcf@infradead.org/
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 drivers/clk/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index f6b82e0b9703..db3bca5f4ec9 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -96,6 +96,7 @@ config CLK_IMX8QXP
 	depends on (ARCH_MXC && ARM64) || COMPILE_TEST
 	depends on IMX_SCU && HAVE_ARM_SMCCC
 	select MXC_CLK_SCU
+	select MXC_CLK
 	help
 	  Build the driver for IMX8QXP SCU based clocks.
 
-- 
2.34.1

On 9/21/23 02:36, Abel Vesa wrote:
> If the i.MX8QXP clock provider is built-in but the MXC_CLK is
> built as module, build fails:
> 
> aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
> clk-imx8-acm.c:(.text+0x3d0): undefined reference to `imx_check_clk_hws'
> 
> Fix that by selecting MXC_CLK in case of CLK_IMX8QXP.
> 
> Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
> Closes: https://lore.kernel.org/all/8b77219e-b59e-40f1-96f1-980a0b2debcf@infradead.org/
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/clk/imx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index f6b82e0b9703..db3bca5f4ec9 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -96,6 +96,7 @@ config CLK_IMX8QXP
>  	depends on (ARCH_MXC && ARM64) || COMPILE_TEST
>  	depends on IMX_SCU && HAVE_ARM_SMCCC
>  	select MXC_CLK_SCU
> +	select MXC_CLK
>  	help
>  	  Build the driver for IMX8QXP SCU based clocks.
>  

-- 
~Randy

> Subject: [PATCH] clk: imx: Select MXC_CLK for CLK_IMX8QXP
>
> If the i.MX8QXP clock provider is built-in but the MXC_CLK is built as module,
> build fails:
>
> aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function
> `imx8_acm_clk_probe':
> clk-imx8-acm.c:(.text+0x3d0): undefined reference to `imx_check_clk_hws'
>
> Fix that by selecting MXC_CLK in case of CLK_IMX8QXP.
>
> Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
> Closes:
> https://lore.ke/
> rnel.org%2Fall%2F8b77219e-b59e-40f1-96f1-
> 980a0b2debcf%40infradead.org%2F&data=05%7C01%7Cpeng.fan%40nxp.co
> m%7Ca2722eb731c04b7547cf08dbba864e80%7C686ea1d3bc2b4c6fa92cd9
> 9c5c301635%7C0%7C0%7C638308858240019022%7CUnknown%7CTWFpb
> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
> 6Mn0%3D%7C3000%7C%7C%7C&sdata=B1ItP%2B%2FYZyet73i8CHu31xRisK
> DMewhqSchemxEwzLY%3D&reserved=0
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>

Reviewed-by: Peng Fan <peng.fan@nxp.com>