[PATCH net-next] MAINTAINERS: Add an obsolete entry for LL TEMAC driver

Harini Katakam posted 1 patch 2 years, 4 months ago
MAINTAINERS | 5 +++++
1 file changed, 5 insertions(+)
[PATCH net-next] MAINTAINERS: Add an obsolete entry for LL TEMAC driver
Posted by Harini Katakam 2 years, 4 months ago
LL TEMAC IP is no longer supported. Hence add an entry marking the
driver as obsolete.

Signed-off-by: Harini Katakam <harini.katakam@amd.com>
---
This is an old driver with no bindings doc and hence the maintainers
entry does not contain a link to documentation.
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3dde038545d8..820a7817f02f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -23696,6 +23696,11 @@ F:	Documentation/devicetree/bindings/gpio/xlnx,gpio-xilinx.yaml
 F:	drivers/gpio/gpio-xilinx.c
 F:	drivers/gpio/gpio-zynq.c
 
+XILINX LL TEMAC ETHERNET DRIVER
+L:	netdev@vger.kernel.org
+S:	Obsolete
+F:	drivers/net/ethernet/xilinx/ll_temac*
+
 XILINX PWM DRIVER
 M:	Sean Anderson <sean.anderson@seco.com>
 S:	Maintained
-- 
2.17.1
Re: [PATCH net-next] MAINTAINERS: Add an obsolete entry for LL TEMAC driver
Posted by esben@geanix.com 2 years, 4 months ago
Harini Katakam <harini.katakam@amd.com> writes:

> LL TEMAC IP is no longer supported. Hence add an entry marking the
> driver as obsolete.

Ok. But while that might mean that no new designs should use LL TEMAC
IP, why do we need to declare the driver for it obsolete?

Existing designs using LL TEMAC IP might need to upgrade Linux kernel
also.

/Esben

>
> Signed-off-by: Harini Katakam <harini.katakam@amd.com>
> ---
> This is an old driver with no bindings doc and hence the maintainers
> entry does not contain a link to documentation.
> ---
>  MAINTAINERS | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3dde038545d8..820a7817f02f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -23696,6 +23696,11 @@ F:	Documentation/devicetree/bindings/gpio/xlnx,gpio-xilinx.yaml
>  F:	drivers/gpio/gpio-xilinx.c
>  F:	drivers/gpio/gpio-zynq.c
>  
> +XILINX LL TEMAC ETHERNET DRIVER
> +L:	netdev@vger.kernel.org
> +S:	Obsolete
> +F:	drivers/net/ethernet/xilinx/ll_temac*
> +
>  XILINX PWM DRIVER
>  M:	Sean Anderson <sean.anderson@seco.com>
>  S:	Maintained
Re: [PATCH net-next] MAINTAINERS: Add an obsolete entry for LL TEMAC driver
Posted by Michal Simek 2 years, 4 months ago

On 9/28/23 16:46, esben@geanix.com wrote:
> Harini Katakam <harini.katakam@amd.com> writes:
> 
>> LL TEMAC IP is no longer supported. Hence add an entry marking the
>> driver as obsolete.
> 
> Ok. But while that might mean that no new designs should use LL TEMAC
> IP, why do we need to declare the driver for it obsolete?
> 
> Existing designs using LL TEMAC IP might need to upgrade Linux kernel
> also.

If you want to take responsibility for keeping that driver alive then feel free 
to send a patch on the top and declare it publicly. We are not able to test it 
on these old platforms that's why we are publicly saying that it is end of us.

Thanks,
Michal
Re: [PATCH net-next] MAINTAINERS: Add an obsolete entry for LL TEMAC driver
Posted by Jakub Kicinski 2 years, 4 months ago
On Fri, 29 Sep 2023 08:06:46 +0200 Michal Simek wrote:
> > Ok. But while that might mean that no new designs should use LL TEMAC
> > IP, why do we need to declare the driver for it obsolete?
> > 
> > Existing designs using LL TEMAC IP might need to upgrade Linux kernel
> > also.  
> 
> If you want to take responsibility for keeping that driver alive then feel free 
> to send a patch on the top and declare it publicly. We are not able to test it 
> on these old platforms that's why we are publicly saying that it is end of us.

Why Obsolete tho? There's no other driver for this IP, so Orphan sounds
more accurate. Please change it to Orphan.
RE: [PATCH net-next] MAINTAINERS: Add an obsolete entry for LL TEMAC driver
Posted by Katakam, Harini 2 years, 4 months ago
Hi Jakub,

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Wednesday, October 4, 2023 8:17 PM
> To: Simek, Michal <michal.simek@amd.com>
> Cc: esben@geanix.com; Katakam, Harini <harini.katakam@amd.com>;
> davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> jsc@umbraculum.org; christophe.jaillet@wanadoo.fr;
> netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; harinikatakamlinux@gmail.com; Pandey, Radhey
> Shyam <radhey.shyam.pandey@amd.com>
> Subject: Re: [PATCH net-next] MAINTAINERS: Add an obsolete entry for LL
> TEMAC driver
> 
> On Fri, 29 Sep 2023 08:06:46 +0200 Michal Simek wrote:
> > > Ok. But while that might mean that no new designs should use LL TEMAC
> > > IP, why do we need to declare the driver for it obsolete?
> > >
> > > Existing designs using LL TEMAC IP might need to upgrade Linux kernel
> > > also.
> >
> > If you want to take responsibility for keeping that driver alive then feel free
> > to send a patch on the top and declare it publicly. We are not able to test it
> > on these old platforms that's why we are publicly saying that it is end of us.
> 
> Why Obsolete tho? There's no other driver for this IP, so Orphan sounds
> more accurate. Please change it to Orphan.

I just noticed that this patch was already applied on net-next. So, I sent a patch
on top updating it from Obsolete to Orphan.

Regards,
Harini
Re: [PATCH net-next] MAINTAINERS: Add an obsolete entry for LL TEMAC driver
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 4 months ago
Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 20 Sep 2023 17:20:47 +0530 you wrote:
> LL TEMAC IP is no longer supported. Hence add an entry marking the
> driver as obsolete.
> 
> Signed-off-by: Harini Katakam <harini.katakam@amd.com>
> ---
> This is an old driver with no bindings doc and hence the maintainers
> entry does not contain a link to documentation.
> 
> [...]

Here is the summary with links:
  - [net-next] MAINTAINERS: Add an obsolete entry for LL TEMAC driver
    https://git.kernel.org/netdev/net-next/c/19f5eef8bf73

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html